Hi Johan,
>+static int rfcomm_accept_secure(struct hci_conn *conn, struct
>+rfcomm_dlc *d) {
>+ BT_DBG("");
>+
>+ if (d->sec_level != BT_SECURITY_HIGH)
>+ return 1; /* Accept */
>+
>+ if (conn->key_type == HCI_LK_AUTH_COMBINATION ||
>+ (conn->key_type == HCI_LK_COMBINATION &&
>+ conn->pin_length == 16))
>+ return 1;
>+
>+ return 0; /* Reject */
>+}
>+
I don't know what's your approach to changing hciops behaviour, but I can guess we should not change it.
If it so, I would add
>+static int rfcomm_accept_secure(struct hci_conn *conn, struct
>+rfcomm_dlc *d) {
>+ BT_DBG("");
>+
/* Secure link is not supported in non mgmtops */
if (!test_bit(HCI_MGMT, &hdev->flags))
return 1;
>+ if (d->sec_level != BT_SECURITY_HIGH)
>+ return 1; /* Accept */
...
This way SECURITY_HIGH for hciops will behave as it's now (pin code less then 16 digit will be accepted).
Do you agree?
/Waldek--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
