Hi Johan, On Tue, Apr 19, 2011 at 5:58 PM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > Hi Briglia, > > On Tue, Apr 19, 2011, anderson.briglia@xxxxxxxxxxxxx wrote: >> From: Johan Hedberg <johan.hedberg@xxxxxxxxx> >> >> This patch adds start_discovery and stop_discovery commands to the >> management interface. Right now their implementation is fairly >> simplistic and the parameters are fixed to what user space has >> defaulted to so far. >> This is the very initial phase for discovery implementation into >> the kernel. Next steps include name resolution, LE scanning and >> bdaddr type handling. >> >> Signed-off-by: Johan Hedberg <johan.hedberg@xxxxxxxxx> >> Signed-off-by: Anderson Briglia <anderson.briglia@xxxxxxxxxxxxx> >> --- >> include/net/bluetooth/mgmt.h | 4 ++ >> net/bluetooth/mgmt.c | 77 +++++++++++++++++++++++++++++++++++++++++- >> 2 files changed, 80 insertions(+), 1 deletions(-) > > I'd appreciate it if you'd check with me first before going about > sending patches in my name that I haven't 100% authored. There are e.g. > some coding style things I'd have cleaned up before making this public. > Depending on the amount of code changed (maybe not enough for this case > though) you could have even put yourself as author and simply mentioned > "Based on original code by Johan..." somewhere in the commit message. Yes, you're right. Actually I thought just the "Signed-off-by" adding myself would be enough since the code is pretty much the same and you had already sent this few weeks ago. Anyway I should contact you first before send to the mailing list, sorry. What do you prefer? I modify the commit message and the patch authoring (and send it again)? Which coding style issues did you notice? Regards, Anderson Briglia > > Johan > -- INdT - Instituto Nokia de tecnologia +55 2126 1122 http://techblog.briglia.net -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
