Re: [PATCH] Bluetooth: Fix unconditional call to mgmt interface in hci_event.c

[Szymon Janc <szymon.janc@xxxxxxxxx>]

> Hi Szymon,

Hi Marcel,

> please just exit the function if flag is not set:
> 
> 	if (!test_bit(...))
> 		return
> 
> > -	mgmt_read_local_oob_data_reply_complete(hdev->id, rp->hash,
> > +	if (test_bit(HCI_MGMT, &hdev->flags))
> > +		mgmt_read_local_oob_data_reply_complete(hdev->id, rp->hash,
> >  						rp->randomizer, rp->status);
> >  }

Other hci_cc_*_reply functions do
    if (test_bit(..))
        mgmt_call();

I'd prefer to keep the same convention for all of them.

BR,
Szymon Janc
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html