Re: [PATCH] Remove unused variable in mgmtops plugin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

On Tue, Mar 29, 2011 at 2:50 PM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote:
> Hi Claudio,
>
> On Tue, Mar 29, 2011, Claudio Takahasi wrote:
>> ---
>> Âplugins/mgmtops.c | Â Â1 -
>> Â1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/plugins/mgmtops.c b/plugins/mgmtops.c
>> index 65b32e6..3f96017 100644
>> --- a/plugins/mgmtops.c
>> +++ b/plugins/mgmtops.c
>> @@ -1410,7 +1410,6 @@ static void mgmt_cleanup(void)
>> Â{
>> Â Â Â g_free(controllers);
>> Â Â Â controllers = NULL;
>> - Â Â max_index = -1;
>>
>> Â Â Â if (mgmt_sock >= 0) {
>> Â Â Â Â Â Â Â close(mgmt_sock);
>
> I don't understand the purpose of this patch. You're neither removing a
> variable (just removing an assignment) nor is the variable you're
> touching unused.
>
> Johan
>

No comment!
I am not working drunk! Maybe blind! ;-)

Claudio.
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux