Hi Vinicius, On Mon, Mar 28, 2011 at 8:33 PM, Vinicius Costa Gomes <vinicius.gomes@xxxxxxxxxxxxx> wrote: > Hi Johan, > > On 21:01 Fri 25 Mar, Vinicius Costa Gomes wrote: >> Hi, >> >> The move itself is pretty simple, but when implementing it, I took a decision >> and I would like to hear your opinion about it. > > There were problems with some useless includes. I will send another version > soon. But the question below remains. > >> >> With this patch series, the behaviour is that we never disconnect from >> a LE device unless we are told so, i.e. org.bluez.Device.Disconnect(), >> is that what is expected from us? In my opinion, the profiles should define how to manage connections. For LE re-connections should be avoided since the remote disables the advertising when the connection is established. Keep the link up seems to be acceptable for now, but for the final solution we need to disconnect based on the registered "watchers" and profile inputs. Some profiles such as proximity keeps the devices always connected and auto-reconnect, others require user interaction. Cheers, Claudio. >> >> >> Cheers, >> -- >> >> Vinicius Costa Gomes (6): >>  Move Attrib client to the core >>  Register Attrib interface when loading device from storage >>  Register Attrib interface after Primary Service discovery >>  Remove _init and _exit methods from Attrib client >>  Add support for re-using the attrib channel >>  Fix disconnecting when primary service discovery is done >> >> ÂMakefile.am   Â|  Â4 ++-- >> Âattrib/client.c Â|  49 ++++++++++++++++++------------------------------- >> Âattrib/client.h Â|  Â6 +++--- >> Âattrib/manager.c |  47 ----------------------------------------------- >> Âsrc/adapter.c  Â|  Â5 +++++ >> Âsrc/device.c   |  20 +++++++++++++------- >> Â6 files changed, 41 insertions(+), 90 deletions(-) >> >> -- >> 1.7.4.1 >> > > Cheers, > -- > Vinicius > -- > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
