Hi Gustavo,
On Thu, Mar 24, 2011 at 8:57 PM, Gustavo F. Padovan
<padovan@xxxxxxxxxxxxxx> wrote:
> Hi Andrei,
>
> * Emeltchenko Andrei <Andrei.Emeltchenko.news@xxxxxxxxx> [2011-03-24 17:16:07 +0200]:
>
>> From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
>>
>> info_timer takes care about removed code
>>
>> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
>> ---
>> net/bluetooth/l2cap_core.c | 12 +++---------
>> 1 files changed, 3 insertions(+), 9 deletions(-)
>>
>> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
>> index fd58b8f..4255f00 100644
>> --- a/net/bluetooth/l2cap_core.c
>> +++ b/net/bluetooth/l2cap_core.c
>> @@ -2472,16 +2472,10 @@ static inline int l2cap_information_rsp(struct l2cap_conn *conn, struct l2cap_cm
>> return 0;
>> }
>>
>> - del_timer(&conn->info_timer);
>> -
>> - if (result != L2CAP_IR_SUCCESS) {
>> - conn->info_state |= L2CAP_INFO_FEAT_MASK_REQ_DONE;
>> - conn->info_ident = 0;
>> -
>> - l2cap_conn_start(conn);
>
> Are you sure? Does remove this code won't create a delay to call
> l2cap_conn_start()?
Yes, but the difference is only with delay. I believe that this way it
will be cleaner.
Do you think that it could cause problems?
Regards,
Andrei
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
