Hi Szymon, Some coding style issues that still need fixing before this can be pushed upstream: On Thu, Mar 24, 2011, Szymon Janc wrote: > +static int hciops_read_local_oob_data (int index) No space before ( > +static int hciops_add_remote_oob_data (int index, bdaddr_t *bdaddr, > + uint8_t *hash, uint8_t *randomizer) Same here. > +static int hciops_remove_remote_oob_data (int index, bdaddr_t *bdaddr) And here. > +static int mgmt_read_local_oob_data (int index) And here. > +static int mgmt_add_remote_oob_data (int index, bdaddr_t *bdaddr, > + uint8_t *hash, uint8_t *randomizer) And here. > +static int mgmt_remove_remote_oob_data (int index, bdaddr_t *bdaddr) And here. > +static void (*local_oob_read_cb)(struct btd_adapter *adapter, uint8_t *hash, > + uint8_t *randomizer) = NULL; Usually we try to avoid unnecessary typedefs, but since this function pointer type is used in three different places and takes several arguments, I think it'd make sense to have a typedef for it in oob.h, e.g. oob_read_cb_t > +void oob_register_cb( void (*cb)(struct btd_adapter *adapter, uint8_t *hash, > + uint8_t *randomizer)) No space before between ( and void Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
