Hi, > No, I don't. This patch is merely because all hcidump parsers (hci, > l2cap, etc) are done inline. > > On Thu, Mar 24, 2011 at 6:24 AM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > > Hi André, > > > > On Wed, Mar 23, 2011, Andre Dieb Martins wrote: > >> --- > >> parser/att.c | 32 ++++++++++++++++---------------- > >> 1 files changed, 16 insertions(+), 16 deletions(-) > > > > Do you have some measurements that show that inlining actually has a > > noticable effect? You're also missing the justification for this change > > in the commit message. Personally I think that we should have most (if not all) of static functions uninlined and leave inlining decision to compiler (i.e. -finline-functions) Inlining functions based on "strong feelings and experience" or "function is short" without proper profiling this is just pure guesswork and can easily lead to unwanted results. -- BR Szymon Janc -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
