[bluez/bluez] d26a7f: tools: iso-tester: add inclusion of time.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  Branch: refs/heads/master
  Home:   https://github.com/bluez/bluez
  Commit: d26a7f96cdd4250f4de3792fd647c3b92581712e
      https://github.com/bluez/bluez/commit/d26a7f96cdd4250f4de3792fd647c3b92581712e
  Author: Christian Eggers <ceggers@xxxxxxx>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M tools/iso-tester.c

  Log Message:
  -----------
  tools: iso-tester: add inclusion of time.h

Inclusion of <linux/errqueue.h> requires that 'struct timespec' has
already been defined:

| In file included from ../bluez-5.79/tools/iso-tester.c:21:
| /usr/include/linux/errqueue.h:57:25: error: array type has incomplete element type 'struct timespec'
|    57 |         struct timespec ts[3];
|       |                         ^~


  Commit: 6f26f2f8de7f57fc8e885328e6b73d95bf227b97
      https://github.com/bluez/bluez/commit/6f26f2f8de7f57fc8e885328e6b73d95bf227b97
  Author: Christian Eggers <ceggers@xxxxxxx>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M mesh/agent.c
    M mesh/appkey.c
    M mesh/cfgmod-server.c
    M mesh/crypto.c
    M mesh/dbus.c
    M mesh/friend.c
    M mesh/keyring.c
    M mesh/main.c
    M mesh/manager.c
    M mesh/mesh-config-json.c
    M mesh/mesh-io-generic.c
    M mesh/mesh-io-mgmt.c
    M mesh/mesh-io-unit.c
    M mesh/mesh-io.c
    M mesh/mesh-mgmt.c
    M mesh/mesh.c
    M mesh/model.c
    M mesh/net-keys.c
    M mesh/net.c
    M mesh/node.c
    M mesh/pb-adv.c
    M mesh/prov-acceptor.c
    M mesh/prov-initiator.c
    M mesh/prvbeac-server.c
    M mesh/remprv-server.c
    M mesh/rpl.c
    M src/shared/btp.c
    M src/shared/io-ell.c
    M src/shared/mainloop-ell.c
    M src/shared/timeout-ell.c
    M tools/mesh/cfgcli.c
    M tools/mesh/keys.c
    M tools/mesh/remote.c
    M tools/mesh/util.c

  Log Message:
  -----------
  mesh: include <time.h> before <ell/ell.h>

I get many of such warnings:

In file included from ../bluez-5.79/ell/ell.h:8,
                 from ../bluez-5.79/mesh/prov-initiator.c:15:
../bluez-5.79/ell/time-private.h:15:43: warning: 'struct timespec' declared inside parameter list will not be visible outside of this definition or declaration
   15 | uint64_t _time_from_timespec(const struct timespec *ts);
      |                                           ^~~~~~~~

It seems that there's no guarantee that 'struct timespec' will be
available via <sys/time.h>, so include <time.h> directly [1]

[1] https://libc-alpha.sourceware.narkive.com/yb0aXzSp/defining-timespec-in-time-h-or-sys-time-h#post3


  Commit: ba9f9fbde34a3f5841eab4b94ed1d618fb4988a2
      https://github.com/bluez/bluez/commit/ba9f9fbde34a3f5841eab4b94ed1d618fb4988a2
  Author: Christian Eggers <ceggers@xxxxxxx>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M tools/btpclient.c

  Log Message:
  -----------
  tools/btpclient: include <time.h> before <ell/ell.h>

It seems that there's no guarantee that 'struct timespec' will be
available via <sys/time.h>, so include <time.h> directly [1]

[1] https://libc-alpha.sourceware.narkive.com/yb0aXzSp/defining-timespec-in-time-h-or-sys-time-h#post3


  Commit: 50fd1d0cc4c8501b6dd9e2e386529f88975298d7
      https://github.com/bluez/bluez/commit/50fd1d0cc4c8501b6dd9e2e386529f88975298d7
  Author: Christian Eggers <ceggers@xxxxxxx>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M client/player.c

  Log Message:
  -----------
  client/player: fix printf format mismatch

%zd is meant for 'size_t' rather than 'off_t'. As there is no printf
length modifier for 'off_t', cast to a standard type which should be
large enough for on all platforms.


  Commit: 50a01b0c17e9c46b7d1ded7cae7df5ea029819dc
      https://github.com/bluez/bluez/commit/50a01b0c17e9c46b7d1ded7cae7df5ea029819dc
  Author: Christian Eggers <ceggers@xxxxxxx>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M src/shared/bap.c

  Log Message:
  -----------
  shared/bap: fix printf format mismatch

struct iovec::iov_len is 'size_t' rather than 'long int'.
https://man7.org/linux/man-pages/man3/iovec.3type.html


Compare: https://github.com/bluez/bluez/compare/77524358658a...50a01b0c17e9

To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux