Re: [PATCH v5 1/2] dt-bindings: net: bluetooth: nxp: Add support to set BD address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Neeraj,


Thank you for your prompt reply.

Am 20.02.25 um 12:59 schrieb Neeraj Sanjay Kale:

Am 20.02.25 um 12:41 schrieb Neeraj Sanjay Kale:
Allow user to set custom BD address for NXP chipsets.

Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@xxxxxxx>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
---
v2: Add allOf and unevaluatedProperties: false (Krzysztof)
v3: Drop local-bd-address: true (Krzysztof)
---
   .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml   | 6 +++++-
   1 file changed, 5 insertions(+), 1 deletion(-)

diff --git
a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
index 0a2d7baf5db3..a84c1c21b024 100644
--- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
+++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
@@ -17,6 +17,9 @@ description:
   maintainers:
     - Neeraj Sanjay Kale <neeraj.sanjaykale@xxxxxxx>

+allOf:
+  - $ref: bluetooth-controller.yaml#
+
   properties:
     compatible:
       enum:
@@ -43,7 +46,7 @@ properties:
   required:
     - compatible

-additionalProperties: false
+unevaluatedProperties: false

How is this diff related to the change mentioned in the commit message?

This is based on review comment from Krzysztof in V1 DT patch.
allOf ref will import all properties defined in bluetooth-controller.yaml, including local-bd-address:
https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/net/bluetooth/bluetooth-controller.yaml#L18

Thank you. I’d include this in the commit message, but my comment was about the replacement of `additionalProperties` by `unevaluatedProperties`.


   examples:
     - |
@@ -54,5 +57,6 @@ examples:
               fw-init-baudrate = <3000000>;
               firmware-name = "uartuart8987_bt_v0.bin";
               device-wakeup-gpios = <&gpio 11 GPIO_ACTIVE_HIGH>;
+            local-bd-address = [66 55 44 33 22 11];
           };
       };

Kind regards,

Paul




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux