Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>: On Wed, 29 Jan 2025 18:23:16 +0100 you wrote: > When checking if the new desired device flags are already pending, we > should compare them against the XOR of current flags and desired flags, > i.e. the flags that are going to change. > > For example, let's assume the following situation: > - We have a device with `current_flags == DEVICE_FLAG_REMOTE_WAKEUP` > (i.e. 1) > - We want to disable the `wake_allowed` property > - `device_set_wake_allowed()` will call `adapter_set_device_flags()` > with `flags == 0` > - When in `adapter_set_device_flags()`, we'll have: > - current == 1 > - pending == 0 > - flags == 0 > In this situation `flags == (flags & pending)` would not return what > we'd expect. > > [...] Here is the summary with links: - [BlueZ] adapter: Fix the pending changing flags check https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0acdf186fcde You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html