Re: [PATCH] Bluetooth: Unnecessary braces around single line statment.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Jeremy,


Thank you for your patch. Could you please make the summary/title a statement, and remove the dot/period at the end:

Bluetooth: Remove unnecessary braces around single line statement

Am 25.01.25 um 17:58 schrieb deaner92@xxxxxxxxx:
From: Jeremy Clifton <deaner92@xxxxxxxxx>

Warning found with checkpatch.pl script. Removed unnecessary braces.

I’d use imperative mood for the second sentence:

Remove unnecessary braces.

Also please add a Fixes: tag.

Signed-off-by: Jeremy Clifton <deaner92@xxxxxxxxx>
---
  drivers/bluetooth/bfusb.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c
index cab93935cc7f..0d6ad50da046 100644
--- a/drivers/bluetooth/bfusb.c
+++ b/drivers/bluetooth/bfusb.c
@@ -365,9 +365,8 @@ static void bfusb_rx_complete(struct urb *urb)
  			buf   += 3;
  		}
- if (count < len) {
+		if (count < len)
  			bt_dev_err(data->hdev, "block extends over URB buffer ranges");
-		}
if ((hdr & 0xe1) == 0xc1)
  			bfusb_recv_block(data, hdr, buf, len);

Reviewed-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>


Kind regards,

Paul




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux