Re: [PATCH BlueZ] shared/shell: add proper line clean to bt_shell_printf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 17, 2025 at 01:17:31PM -0500, Luiz Augusto von Dentz wrote:
> Hi Denis,
> 
> On Fri, Jan 17, 2025 at 1:08 PM Denis Burkov <hitechshell@xxxxxxx> wrote:
> 
> We normally expect some description of why this change is required,
> for instance what is the output with and without your changes here,
> are there artifacts if we don't use rl_clear_visible_line?

in some terminals (or all?) the line is not cleared before a new one is output
(for example, if you turn on scanning and then try to write something to the terminal,
the output will be mixed - you will get something like this

[JBL T450BT]# h[NEW] Device ****
[JBL T450BT]# he[NEW] Device ****
[JBL T450BT]# hell[NEW] Device ****
[JBL T450BT]# hello[NEW] Device ****
[JBL T450BT]# hello[NEW] Device ****

where "Device ****" is the line that was actually fed to bt_shell_printf

this was reproduced at least on simple terminal and alacritty (on gentoo)




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux