Re: [PATCH v2] Bluetooth: qca: Support downloading board ID specific NVM for WCN6855

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

On Mon, Jan 13, 2025 at 4:24 AM Johan Hovold <johan@xxxxxxxxxx> wrote:
>
> Hi Luiz,
>
> On Fri, Dec 13, 2024 at 10:22:05AM +0100, Johan Hovold wrote:
> > On Sat, Nov 16, 2024 at 07:49:23AM -0800, Zijun Hu wrote:
> > > For WCN6855, board ID specific NVM needs to be downloaded once board ID
> > > is available, but the default NVM is always downloaded currently, and
> > > the wrong NVM causes poor RF performance which effects user experience.
> > >
> > > Fix by downloading board ID specific NVM if board ID is available.
>
> > > Fixes: 095327fede00 ("Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6855")
> > > Cc: stable@xxxxxxxxxxxxxxx # 6.4
> > > Reviewed-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> > > Tested-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> > > Tested-by: Steev Klimaszewski <steev@xxxxxxxx>
> > > Tested-by: Jens Glathe <jens.glathe@xxxxxxxxxxxxxxxxxxxxxx>
> > > Signed-off-by: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
> >
> > > I will help to backport it to LTS kernels ASAP once this commit
> > > is mainlined.
> > > ---
> > > Changes in v2:
> > > - Correct subject and commit message
> > > - Temporarily add nvm fallback logic to speed up backport.
> > > — Add fix/stable tags as suggested by Luiz and Johan
> > > - Link to v1: https://lore.kernel.org/r/20241113-x13s_wcn6855_fix-v1-1-15af0aa2549c@xxxxxxxxxxx
> >
> > The board-specific NVM configuration files have now been included in the
> > linux-firmware-20241210 release and are making their way into the
> > distros (e.g. Arch Linux ARM and Fedora now ship them).
> >
> > Could we get this merged for 6.13-rc (and backported) so that Lenovo
> > ThinkPad X13s users can finally enjoy excellent Bluetooth range? :)
>
> This fix is still pending in your queue (I hope) and I was hoping you
> would be able to get it into 6.13-rc. The reason, apart from this being
> a crucial fix for users of this chipset, was also to avoid any conflicts
> with the new "rampatch" firmware name feature (which will also
> complicate backporting somewhat).
>
> Those patches were resent on January 7 and have now been merged for 6.14
> (presumably):
>
>         https://lore.kernel.org/all/20250107092650.498154-1-quic_chejiang@xxxxxxxxxxx/
>
> How do we handle this? Can you still get this fix into 6.13 or is it
> now, as I assume, too late for that?
>
> Zijun, depending on Luiz' reply, can you look into rebasing on top of the
> patches now queued for linux-next?
>
> Johan

I will send a pull request later this week that includes everything on
bluetooth-next, so it has been merged on bluetooth-next it should be
fine, it hasn't been merged then please resend it.

-- 
Luiz Augusto von Dentz





[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux