Hi Greg, On Wed, Jan 8, 2025 at 7:34 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Fri, Jan 03, 2025 at 11:20:20AM +0800, Hsin-chen Chuang wrote: > > Allow sysfs to trigger reset via the cmd_timeout function in hci device. > > This is required to recover devices that are not responsive from > > userspace. > > > > Also remove the cmd timeout count in btusb since we only ever allow one > > command in flight at a time. We should always reset after a single > > command times out. > > > > Signed-off-by: Hsin-chen Chuang <chharry@xxxxxxxxxxxx> > > --- > > This commit has been tested on a Chromebook by running > > `echo 1 > /sys/class/bluetooth/hci0/reset` > > You forgot the required Documentation/ABI/ update for your new sysfs > file :( Looks like I've missed that when reviewing these changes, anyway no pull-request has been made, I assume we should follow what is documentation on Documentation/ABI/README? Does it include debugfs entries as well or only sysfs are required to be documented? > thanks, > > greg k-h -- Luiz Augusto von Dentz