Re: [PATCH BlueZ v2] Leave config files writable for owner

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2024-12-09 at 16:40 +0100, Fiona Klute wrote:
> This is needed for builds running as non-root users, so the build
> process and any distribution tools can create/move/delete files in
> the
> config directory without adjusting permissions separately. Limiting
> writes from the running service needs to be done in the systemd unit
> (already the case) or init script.
> 
> See also:
> https://lore.kernel.org/linux-bluetooth/4d1206df-598b-4a68-8655-74981b62ecca@xxxxxx/T/
> ---
> Changes v1 -> v2:
> * Explicitly mention in commit message that write permission is
> needed
>   for build as non-root user.
> 
>  Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 297d0774c..29018a91c 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -32,7 +32,7 @@ confdir = $(sysconfdir)/bluetooth
>  statedir = $(localstatedir)/lib/bluetooth
>  
>  bluetoothd-fix-permissions:
> -	install -dm555 $(DESTDIR)$(confdir)
> +	install -dm755 $(DESTDIR)$(confdir)
>  	install -dm700 $(DESTDIR)$(statedir)


Reviewed-by: Bastien Nocera <hadess@xxxxxxxxxx>





[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux