On 05/12/2024 11:22, Cheng Jiang wrote: > @@ -2309,8 +2322,10 @@ static int qca_serdev_probe(struct serdev_device *serdev) > qcadev->serdev_hu.serdev = serdev; > data = device_get_match_data(&serdev->dev); > serdev_device_set_drvdata(serdev, qcadev); > - device_property_read_string(&serdev->dev, "firmware-name", > - &qcadev->firmware_name); > + of_property_read_string_index(serdev->dev.of_node, "firmware-name", > + 0, &qcadev->firmware_name); > + of_property_read_string_index(serdev->dev.of_node, "firmware-name", > + 1, &qcadev->rampatch_name); No, that's entirely different API. You are not supposed to drop here device-API and revert to OF. It is not a related change, either. Best regards, Krzysztof
