Sure, >I've pushed the first two patches in this set, but it's gonna >take quite a bit longer to properly review the rest (at a >quick glance I noticed at least some coding style stuff with >over 80-character lines). Yes, I guess you refer to eg. case SAP_SET_TRANSPORT_PROTOCOL_REQ: if (msg->nparam == 0x01 && msg->param->id == SAP_PARAM_ID_TRANSPORT_PROTOCOL && ntohs(msg->param->len) == SAP_PARAM_ID_TRANSPORT_PROTOCOL_LEN && (*msg->param->val == SAP_TRANSPORT_PROTOCOL_T0 || *msg->param->val == SAP_TRANSPORT_PROTOCOL_T1)) return 0; Well, I didn't know how to spit up something like "ntohs(msg->param->len) == SAP_PARAM_ID_TRANSPORT_PROTOCOL_LEN &&" correctly. Any sugestion? /Waldek -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html