Hi Luiz,
Friendly reminder.
>-----Original Message-----
>From: K, Kiran <kiran.k@xxxxxxxxx>
>Sent: Tuesday, October 22, 2024 2:42 PM
>To: linux-bluetooth@xxxxxxxxxxxxxxx
>Cc: Srivatsa, Ravishankar <ravishankar.srivatsa@xxxxxxxxx>; Tumkur Narayan,
>Chethan <chethan.tumkur.narayan@xxxxxxxxx>; Devegowda, Chandrashekar
><chandrashekar.devegowda@xxxxxxxxx>; Satija, Vijay <vijay.satija@xxxxxxxxx>;
>K, Kiran <kiran.k@xxxxxxxxx>
>Subject: [PATCH v2] Bluetooth: btintel: Direct exception event to bluetooth
>stack
>
>Have exception event part of HCI traces which helps for debug.
>
>snoop traces:
>> HCI Event: Vendor (0xff) plen 79
> Vendor Prefix (0x8780)
> Intel Extended Telemetry (0x03)
> Unknown extended telemetry event type (0xde)
> 01 01 de
> Unknown extended subevent 0x07
> 01 01 de 07 01 de 06 1c ef be ad de ef be ad de
> ef be ad de ef be ad de ef be ad de ef be ad de
> ef be ad de 05 14 ef be ad de ef be ad de ef be
> ad de ef be ad de ef be ad de 43 10 ef be ad de
> ef be ad de ef be ad de ef be ad de
>
>Fixes: af395330abed ("Bluetooth: btintel: Add Intel devcoredump support")
>Signed-off-by: Kiran K <kiran.k@xxxxxxxxx>
>---
> drivers/bluetooth/btintel.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c index
>e122dff855ba..d496cf2c3411 100644
>--- a/drivers/bluetooth/btintel.c
>+++ b/drivers/bluetooth/btintel.c
>@@ -3361,13 +3361,12 @@ int btintel_diagnostics(struct hci_dev *hdev, struct
>sk_buff *skb)
> case INTEL_TLV_TEST_EXCEPTION:
> /* Generate devcoredump from exception */
> if (!hci_devcd_init(hdev, skb->len)) {
>- hci_devcd_append(hdev, skb);
>+ hci_devcd_append(hdev, skb_clone(skb,
>GFP_ATOMIC));
> hci_devcd_complete(hdev);
> } else {
> bt_dev_err(hdev, "Failed to generate devcoredump");
>- kfree_skb(skb);
> }
>- return 0;
>+ break;
> default:
> bt_dev_err(hdev, "Invalid exception type %02X", tlv->val[0]);
> }
>--
>2.40.1
Thanks,
Kiran
