Hi Daniel, On Mon, Oct 28, 2024 at 4:51 PM Daniel Beer <daniel.beer@xxxxxxxxxxxxxxxxx> wrote: > > On Mon, Oct 28, 2024 at 01:37:30PM -0400, Luiz Augusto von Dentz wrote: > > Ok, then perhaps it is a good idea to have these applied, that said it > > would have been great to have this type of test automation upstream in > > the future so we can catch regressions if we ever change this logic > > for some reason. > > Hi Luiz, > > I would like to be able to share the test setup, but unfortunately it's > a difficult-to-replicate hardware setup plus some proprietary control > pieces. Ok, well I like to have it perhaps running under our test-runner environment wit emulated controller to make it part of our CI, anyway this probably require much more resources to put it together. > I see that the patches failed a lint check due to the trailing period in > the commit message. Would you like me to resubmit, or are you happy to > edit those? No need, Ive fixed them myself before pushing. > > Cheers, > Daniel > > -- > Daniel Beer > Director of Firmware Engineering at Igor Institute > daniel.beer@xxxxxxxxxxxxxxxxx or +64-27-420-8101 > Offices in Seattle, San Francisco, and Vancouver BC or (206) 494-3312 -- Luiz Augusto von Dentz
