Hi Rafael, Paul, On Wed, Oct 16, 2024 at 8:06 AM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote: > > On Wed, Oct 16, 2024 at 7:12 AM Paul Menzel <pmenzel@xxxxxxxxxxxxx> wrote: > > > > Dear Luiz, > > > > > > Thank you for the patch. > > > > > > Am 14.10.24 um 22:23 schrieb Luiz Augusto von Dentz: > > > From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx> > > > > > > Calls to hci_suspend_dev assumes the system-suspend which doesn't work > > > well when just the device is being suspended because wakeup flag is only > > > set for remote devices that can wakeup the system. > > > > Please mention that you revert most parts of the problematic commit. > > Yes, it would be good to say in the changelog that this is a partial revert. Ack. > > > Reported-by: Rafael J. Wysocki <rafael@xxxxxxxxxx> > > > Reported-by: Heiner Kallweit <hkallweit1@xxxxxxxxx> > > > Reported-by: Kenneth Crudup <kenny@xxxxxxxxx> > > > Fixes: 81b3e33bb054 ("Bluetooth: btusb: Don't fail external suspend requests") > > > > That commit is not in the master branch, > > 610712298b11b2914be00b35abe9326b5dbb62c8 is. Right, looks like I need to rebase to get the updated hashes. > Right. -- Luiz Augusto von Dentz