Re: [PATCH net-next v3 8/9] net: warn, if pf->create does not clear sock->sk on error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH net-next v3 8/9] net: warn, if pf->create does not clear sock->sk on error
From: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>
Date: Mon, 14 Oct 2024 14:40:46 -0700
Authentication-results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="UjMQxEx/"
Authentication-results: smtp.subspace.kernel.org; arc=none smtp.client-ip=52.95.49.90
Authentication-results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com
Authentication-results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.jp
Cc: <alex.aring@xxxxxxxxx>, <alibuda@xxxxxxxxxxxxxxxxx>, <davem@xxxxxxxxxxxxx>, <dsahern@xxxxxxxxxx>, <edumazet@xxxxxxxxxx>, <johan.hedberg@xxxxxxxxx>, <kernel-team@xxxxxxxxxxxxxx>, <kuba@xxxxxxxxxx>, <kuniyu@xxxxxxxxxx>, <linux-bluetooth@xxxxxxxxxxxxxxx>, <linux-can@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-wpan@xxxxxxxxxxxxxxx>, <luiz.dentz@xxxxxxxxx>, <marcel@xxxxxxxxxxxx>, <miquel.raynal@xxxxxxxxxxx>, <mkl@xxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, <pabeni@xxxxxxxxxx>, <socketcan@xxxxxxxxxxxx>, <stefan@xxxxxxxxxxxxxxxxxx>, <willemdebruijn.kernel@xxxxxxxxx>
In-reply-to: <20241014153808.51894-9-ignat@cloudflare.com>
References: <20241014153808.51894-9-ignat@cloudflare.com>

From: Ignat Korchagin <ignat@xxxxxxxxxxxxxx>
Date: Mon, 14 Oct 2024 16:38:07 +0100
> All pf->create implementations have been fixed now to clear sock->sk on
> error, when they deallocate the allocated sk object.
> 
> Put a warning in place to make sure we don't break this promise in the
> future.
> 
> Suggested-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>
> Signed-off-by: Ignat Korchagin <ignat@xxxxxxxxxxxxxx>

Reviewed-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>

Follow-Ups:
- Re: [PATCH net-next v3 8/9] net: warn, if pf->create does not clear sock->sk on error
  - From: Eric Dumazet

References:
- [PATCH net-next v3 8/9] net: warn, if pf->create does not clear sock->sk on error
  - From: Ignat Korchagin

Prev by Date: Re: [PATCH net-next v3 7/9] net: inet6: do not leave a dangling sk pointer in inet6_create()
Next by Date: Re: [PATCH net-next v3 9/9] Revert "net: do not leave a dangling sk pointer, when socket creation fails"
Previous by thread: [PATCH net-next v3 8/9] net: warn, if pf->create does not clear sock->sk on error
Next by thread: Re: [PATCH net-next v3 8/9] net: warn, if pf->create does not clear sock->sk on error
Index(es):
- Date
- Thread

[Index of Archives] [Bluez Devel] [Linux Wireless Networking] [Linux Wireless Personal Area Networking] [Linux ATH6KL] [Linux USB Devel] [Linux Media Drivers] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Big List of Linux Books]