Hi Junho,
There are some check-patch failures on your patchset.
Can you fix these (and any others you find with check-patch) and resubmit?
The ones below are only from patch 1 of 4... patch 3 applied cleanly,
but 2 and 4 also could not be applied until patch 1 is fixed.
Thanks,
Brian
On 10/4/24 12:31 AM, Junho Lee wrote:
- send_net_ack(net, sar_in, expected);
+ if (sar->flags == expected) {
+ /*
+ * According to MshPRTv1.1: 3.5.3.4, if the destination
+ * is a unicast address and a segment is received for a
+ * completed message, it sends one acknowledgment within
+ * a period of:
+ * [acknowledgment delay increment * segment reception interval]
WARNING:LONG_LINE_COMMENT: line over 80 characters
#774: FILE: mesh/net.c:2207:
+ * [acknowledgment delay increment * segment reception
interval]
/* Msg length only definitive on last segment */
if (segO == segN)
- sar_in->len = segN * MAX_SEG_LEN + size;
+ sar->len = segN * MAX_SEG_LEN + size;
+
+ /* Send ACK only if DST is unicast address. */
+ if(IS_UNICAST(dst)) {
ERROR:SPACING: space required before the open parenthesis '('
#875: FILE: mesh/net.c:2283:
+ if(IS_UNICAST(dst)) {
+ * segmented. Flush if it is not segmented or if the transmission
+ * failed.
+ */
+ if (result && segmented) {
+ struct mesh_sar_tx *sar_tx = mesh_sar_tx_new();
+ bool is_unicast = IS_UNICAST(dst);
+ sar_tx->ack_received = false;
WARNING:LINE_SPACING: Missing a blank line after declarations
#1010: FILE: mesh/net.c:3565:
+ bool is_unicast = IS_UNICAST(dst);
+ sar_tx->ack_received = false;
