On 07/10/2024 21:49, Aleksei Vetrov wrote: > Hi Andrej, > > On Wed, Oct 02, 2024 at 04:12:17PM +0200, Andrej Shadura wrote: >> Change the type of len to size_t in both rfcomm_sock_bind and >> rfcomm_sock_getsockopt_old and replace min_t() with min(). > rfcomm_sock_bind doesn't use copy_to_user, are you sure it has the same > issue? > This change produces a compilation error around min expression, as > "kernel test robot" notices below. And I think rfcomm_sock_bind > shouldn't be touched at all, it doesn't use copy_to_user and doesn't > produce compile errors with latest Clang. Thanks, you’re right, I went a bit too far here :) Rebuilding with a different verbosity setting revealed it here as well. > This looks ok. But there is the same pattern in rfcomm_sock_getsockopt > (without old prefix) and it also uses copy_to_user and produces compile > error with latest Clang. > > Could you remove rfcomm_sock_bind patch and apply it to > rfcomm_sock_getsockopt instead? Or I can send my version of the patch: > we've encountered the same compile errors in rfcomm_sock_getsockopt and > rfcomm_sock_getsockopt_old after updating Clang and would like to get it > fixed. Interestingly, it didn’t produce an error on my clang version, but sure, I am amending the patch and will submit it shortly. -- Cheers, Andrej
