Hi Claudio,
On Thu, Mar 10, 2011 at 10:16 AM, Claudio Takahasi
<claudio.takahasi@xxxxxxxxxxxxx> wrote:
> Hi Elvis,
>
> Is it allowed to have notification and indication bits set to the same
> characteristic?
> If it is not allowed you could simplify the logic inside the "for".
The spec does not forbid both indication and notification to be
enabled, as Elvis mentioned.
>> + /* Indication */
>> + if (g_slist_find_custom(channel->indicate,
>> + GUINT_TO_POINTER(handle), handle_cmp)) {
>> + uint8_t pdu[ATT_MAX_MTU];
>> + uint16_t len;
>
> The same declarations(pdu and len) exist for Notification. I suggest
> move to the outer scope.
Actually, it was a suggestion from Johan to move these declarations to
inner scope. But at the time there was only one if() statement, which
justified this.
Anyway, patch is applied, so this can be made into a simple refactor
if you find it better to put in outer scope.
Regards,
--
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
