On Thu, Mar 10, 2011 at 12:14 PM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote:
> Hi Slawek,
>
> On Wed, Mar 02, 2011, lkslawek@xxxxxxxxx wrote:
>> + ret = obex_get_stream_start(os, name);
>> + if (ret < 0)
>> + goto fail;
>> +
>> + return 0;
>> +fail:
>> + return ret;
>> +}
>
> How about just "return obex_get_stream_start(os, name);"?
>
>> + ret = obex_put_stream_start(os, name);
>> + if (ret < 0)
>> + goto fail;
>> +
>> + return 0;
>> +fail:
>> + return ret;
>> +}
>
> Same here.
>
This is ready for upcoming change, where there is also applications
parameter parsing that can fail and return it's own error code.
>> + }
>> +
>> + return 0;
>> +}
>> +static struct obex_service_driver mas = {
>
> Missing empty line before "statis struct ...".
>
I will fix it.
>> static int mas_init(void)
>> {
>> + int err;
>> +
>> + err = obex_service_driver_register(&mas);
>> + if (err < 0)
>> + goto fail_mas_reg;
>> +
>> return 0;
>> +
>> +fail_mas_reg:
>> + return err;
>> }
>
> Just "return obex_service_driver_register(&mas);" should be enough.
This one makes more sense when you look at all patches in this set as a whole.
--
Slawomir Bochenski
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
