Re: [PATCH 1/1] Bluetooth: mgmt: Fix LTK load error in SMP over BREDR scenario

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Felix,

On Tue, Aug 27, 2024 at 4:14 AM Felix Qin <xiaokeqinhealth@xxxxxxx> wrote:
>
> From: Felix Qin <xiaoyao@xxxxxxxxxxxxxx>
>
> Fixes: 59b047bc9808 ("Bluetooth: MGMT/SMP: Fix address type when using SMP over BREDR/LE")
> Signed-off-by: Felix Qin <xiaoyao@xxxxxxxxxxxxxx>
> ---
>  net/bluetooth/mgmt.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index 25979f4283a6..13bba6ad5d95 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -7106,6 +7106,9 @@ static bool ltk_is_valid(struct mgmt_ltk_info *key)
>                 return false;
>
>         switch (key->addr.type) {
> +       case BDADDR_BREDR:
> +               /* ltk over bredr */
> +               return true;
>         case BDADDR_LE_PUBLIC:
>                 return true;
>
> --
> 2.34.1

I thought about doing that but this is not correct according to our
own documentation:

https://github.com/bluez/bluez/blob/master/doc/mgmt-api.txt#L877

There is also the question of why we would need to load BR/EDR
addresses via Load LTK when that is LE bearer specific.

>


-- 
Luiz Augusto von Dentz





[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux