Hi Doug, On Wed, Aug 21, 2024 at 5:19 PM Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > > Hi, > > On Wed, Jul 31, 2024 at 1:29 PM Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > > > > Hi, > > > > On Mon, Jun 10, 2024 at 4:52 PM Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > > > > > > Hi, > > > > > > On Fri, May 17, 2024 at 5:03 PM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote: > > > > > > > > On systems in the field, we are seeing this sometimes in the kernel logs: > > > > Bluetooth: qca_controller_memdump() hci0: hci_devcd_init Return:-95 > > > > > > > > This means that _something_ decided that it wanted to get a memdump > > > > but then hci_devcd_init() returned -EOPNOTSUPP (AKA -95). > > > > > > > > The cleanup code in qca_controller_memdump() when we get back an error > > > > from hci_devcd_init() undoes most things but forgets to clear > > > > QCA_IBS_DISABLED. One side effect of this is that, during the next > > > > suspend, qca_suspend() will always get a timeout. > > > > > > > > Let's fix it so that we clear the bit. > > > > > > > > Fixes: 06d3fdfcdf5c ("Bluetooth: hci_qca: Add qcom devcoredump support") > > > > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > > > > --- > > > > I'm nowhere near an expert on this code so please give extra eyes on > > > > this patch. I also have no idea how to reproduce the problem nor even > > > > how to trigger a memdump to test it. I'd love any advice that folks > > > > could give. ;-) > > > > > > > > drivers/bluetooth/hci_qca.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > Totally fine if you just need more time, but I wanted to follow up and > > > check to see if there is anything you need me to do to help move this > > > patch forward. If not, I'll snooze this patch and check up on it again > > > sometime around the end of July. > > > > It being the end of July, I'm back to check up on this patch. I > > checked mainline and bluetooth-next and I don't see any sign of this > > patch. Is there anything blocking it? Do you need me to repost it or > > take any other actions? > > I feel like I'm shouting into the wind. Am I following some incorrect > process for submitting this patch? Can anyone suggest something I > should do differently to get a response here? Just resend it since it is no longer listed on patchwork it felt off my radar. > Thanks! > > -Doug -- Luiz Augusto von Dentz