Hello, > -----Original Message----- > From: Pauli Virtanen <pav@xxxxxx> > Sent: Tuesday, July 30, 2024 9:45 PM > To: Vlad Pruteanu <vlad.pruteanu@xxxxxxx>; linux-bluetooth@xxxxxxxxxxxxxxx > Cc: Mihai-Octavian Urzica <mihai-octavian.urzica@xxxxxxx>; Iulia Tanasescu > <iulia.tanasescu@xxxxxxx>; Andrei Istodorescu <andrei.istodorescu@xxxxxxx>; > luiz.dentz@xxxxxxxxx > Subject: [EXT] Re: [PATCH BlueZ v4 1/8] doc/media: Add 'broadcasting' state and > 'select' method > > Caution: This is an external email. Please take care when clicking links or opening > attachments. When in doubt, report the message using the 'Report this email' > button > > > Hi, > > ti, 2024-07-30 kello 17:09 +0300, Vlad Pruteanu kirjoitti: > > This adds a new state for transports created by the Broadcast > > Sink. Such transports will remain in the 'idle' state until the > > user calls 'select' on them, at which point they will be moved to > > 'broadcasting'. This allows the user to select the desired BIS as > > the audio server automatically acquires transports that are in this > > state. > > --- > > doc/org.bluez.MediaTransport.rst | 18 +++++++++++++++++- > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > diff --git a/doc/org.bluez.MediaTransport.rst > b/doc/org.bluez.MediaTransport.rst > > index 6e95df8f2..c23d1f59f 100644 > > --- a/doc/org.bluez.MediaTransport.rst > > +++ b/doc/org.bluez.MediaTransport.rst > > @@ -7,7 +7,7 @@ BlueZ D-Bus MediaTransport API documentation > > -------------------------------------------- > > > > :Version: BlueZ > > -:Date: September 2023 > > +:Date: July 2024 > > :Manual section: 5 > > :Manual group: Linux System Administration > > > > @@ -51,6 +51,20 @@ void Release() > > > > Releases file descriptor. > > > > +void Select_transport() > > In the code I see the DBus method names actually are: > > Select() > Unselect() Thank you for pointing this out, it appears that I mistakenly used the names of the actual functions from transport.c > > The DBus names are also conventionally in CamelCase(). > > > +``````````````````````` > > + > > + Applicable only for transports created by a broadcast sink. This moves > > + the transport from 'idle' to 'broadcasting'. This allows the user to > > + select which BISes he wishes to sync to via a 2 step process: > > + 1) the user calls this method, changing the transport's state to idle > > + 2) the audio server detects that the transport is in the 'broadcasting' > > + state and automatically acquires it > > + > > + Possible Errors: > > + > > + :org.bluez.Error.NotAuthorized: > > + > > Properties > > ---------- > > > > @@ -84,6 +98,8 @@ string State [readonly] > > > > :"idle": not streaming > > :"pending": streaming but not acquired > > + :"broadcasting": streaming but not acquired, applicable only for transports > > + created by a broadcast sink > > :"active": streaming and acquired > > > > uint16 Delay [readwrite, optional] > > -- > Pauli Virtanen Regards, Vlad
