Hi Amisha,
On Tue, Jun 25, 2024 at 2:36 AM Amisha Jain <quic_amisjain@xxxxxxxxxxx> wrote:
>
> Update the 'mas_session' structure such that
> manager_emit_transfer_property(os->service_data, "Size")
> will get the proper structure in arguments as
> expected like structure 'obex_transfer' and transfer->path
> won't be populated with inappropriate value.
>
> As there is no new transfer registered during mas connect,
> hence setting the path to NULL to avoid invoking the
> g_dbus_emit_property_changed() property.
>
> Signed-off-by: Amisha Jain <quic_amisjain@xxxxxxxxxxx>
> ---
> obexd/plugins/mas.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/obexd/plugins/mas.c b/obexd/plugins/mas.c
> index 10b972d65..71bf12ad3 100644
> --- a/obexd/plugins/mas.c
> +++ b/obexd/plugins/mas.c
> @@ -51,6 +51,8 @@
> #define ML_BODY_END "</MAP-msg-listing>"
>
> struct mas_session {
> + uint8_t notification_status;
> + char *path;
> struct mas_request *request;
> void *backend_data;
> gboolean finished;
> @@ -59,7 +61,6 @@ struct mas_session {
> GObexApparam *inparams;
> GObexApparam *outparams;
> gboolean ap_sent;
> - uint8_t notification_status;
> };
>
> static const uint8_t MAS_TARGET[TARGET_SIZE] = {
> @@ -125,6 +126,7 @@ static void *mas_connect(struct obex_session *os, int *err)
> goto failed;
>
> manager_register_session(os);
> + mas->path = NULL;
There is something missing here, you introduce a new field and set it
to NULL but you never use it?
> return mas;
>
> --
> 2.17.1
>
>
--
Luiz Augusto von Dentz
