Hi Pauli, On Sat, Jun 15, 2024 at 9:14 AM Pauli Virtanen <pav@xxxxxx> wrote: > > The directions appear to be intended as bitmasks, as > bt_bap_stream_io_dir() will bitwise or linked stream directions. > > Fix the defines to be separate bits. > > Fixes confusion due to BT_BAP_BCAST_SOURCE == BT_BAP_SINK|BT_BAP_SOURCE, > which causes e.g. unicast transports to be in PENDING state after QoS > although this does not make sense for BAP unicast Client. Nice catch. > --- > src/shared/bap-defs.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/shared/bap-defs.h b/src/shared/bap-defs.h > index 2467e816f..75e6950ea 100644 > --- a/src/shared/bap-defs.h > +++ b/src/shared/bap-defs.h > @@ -17,8 +17,8 @@ > > #define BT_BAP_SINK 0x01 > #define BT_BAP_SOURCE 0x02 > -#define BT_BAP_BCAST_SOURCE 0x03 > -#define BT_BAP_BCAST_SINK 0x04 > +#define BT_BAP_BCAST_SOURCE 0x04 > +#define BT_BAP_BCAST_SINK 0x08 To make it clearer I guess we could use the BIT macro to define these. > #define BT_BAP_STREAM_TYPE_UCAST 0x01 > #define BT_BAP_STREAM_TYPE_BCAST 0x02 > -- > 2.45.2 > > -- Luiz Augusto von Dentz
