On 10/06/2024 17:05, Krzysztof Kozlowski wrote: > On 05/06/2024 14:38, Bartosz Golaszewski wrote: >> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> >> >> This adds the power sequencing driver for the PMU modules present on the >> Qualcomm WCN Bluetooth and Wifi chipsets. It uses the pwrseq subsystem >> and knows how to match the sequencer to the consumer device by verifying >> the relevant properties and DT layout. Using this driver will allow the >> BT and WLAN drivers to respect the required delays between enabling the >> two modules. >> > > ... > > >> + >> + ctx->bt_gpio = devm_gpiod_get_optional(dev, "bt-enable", GPIOD_OUT_LOW); >> + if (IS_ERR(ctx->bt_gpio)) >> + return dev_err_probe(dev, PTR_ERR(ctx->bt_gpio), >> + "Failed to get the Bluetooth enable GPIO\n"); >> + >> + ctx->wlan_gpio = devm_gpiod_get_optional(dev, "wlan-enable", >> + GPIOD_OUT_LOW); >> + if (IS_ERR(ctx->wlan_gpio)) >> + return dev_err_probe(dev, PTR_ERR(ctx->wlan_gpio), >> + "Failed to get the WLAN enable GPIO\n"); >> + >> + ctx->clk = devm_clk_get_optional(dev, NULL); > > Your binding does not allow the clock. Do you need it for non-DT platforms? Bah, damn covid, now I see second commit with clocks. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
