On 14:28 Mon 28 Feb, Gustavo F. Padovan wrote: > Hi Vinicius, > > * Vinicius Gomes <vinicius.gomes@xxxxxxxxxxxxx> [2011-02-27 21:49:39 -0300]: > [ ... ] > > > > I have a couple of points against it: > > > > 1. it's only used for one purpose, it says whether to try or not to > > allocate the block cypher, which is done during the adapter > > registration; > > > > 2. If the current way is ok, it would mean that I would need to export > > another method from smp.c, that was something that I tried to > > minimize; > > > > 3. and my weakest argument, seems that there are other similar uses, > > for example enable_mgmt. > > A similar example here is enable_ertm inside l2cap_core.c. It's a L2CAP > related option and should reside inside L2CAP code. > > > > > But if you think the code will be clearer moving that to smp.c, will > > be glad to change. > > I don't see the point on have it on hci code. SMP and Block cypher has > not much to do with HCI. I prefer it on smp.c Fair enough. Will change. > > -- > Gustavo F. Padovan > http://profusion.mobi Cheers, -- Vinicius -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
