Hi Vitaly, * Vitaly Wool <vitalywool@xxxxxxxxx> [2011-02-26 18:52:44 +0100]: > Hi Gustavo, > > On Sat, Feb 26, 2011 at 2:41 AM, Gustavo F. Padovan > <padovan@xxxxxxxxxxxxxx> wrote: > > If we want something "bool" built-in in something "tristate" it can't > > "depend on" the tristate config option. > > > > Report by DaveM: > > > > I give it 'y' just to make it happen, for both, and afterways no > > matter how many times I rerun "make oldconfig" I keep seeing things > > like this in my build: > > > > scripts/kconfig/conf --silentoldconfig Kconfig > > include/config/auto.conf:986:warning: symbol value 'm' invalid for BT_SCO > > include/config/auto.conf:3156:warning: symbol value 'm' invalid for BT_L2CAP > > > > Reported-by: David S. Miller <davem@xxxxxxxxxxxxx> > > Signed-off-by: Gustavo F. Padovan <padovan@xxxxxxxxxxxxxx> > > --- > > net/bluetooth/Kconfig | 6 ++++-- > > 1 files changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/net/bluetooth/Kconfig b/net/bluetooth/Kconfig > > index c6f9c2f..6ae5ec5 100644 > > --- a/net/bluetooth/Kconfig > > +++ b/net/bluetooth/Kconfig > > @@ -31,9 +31,10 @@ menuconfig BT > > to Bluetooth kernel modules are provided in the BlueZ packages. For > > more information, see <http://www.bluez.org/>. > > > > +if BT != n > > + > > config BT_L2CAP > > bool "L2CAP protocol support" > > - depends on BT > > select CRC16 > > help > > L2CAP (Logical Link Control and Adaptation Protocol) provides > > @@ -42,11 +43,12 @@ config BT_L2CAP > > > > config BT_SCO > > bool "SCO links support" > > - depends on BT > > help > > SCO link provides voice transport over Bluetooth. SCO support is > > required for voice applications like Headset and Audio. > > > > +endif > > + > > Ugh, isn't it far cleaner to change initial dependencies to "depends > on BT != n" ? I just followed the same approach as net/ipv6/Kconfig and net/mac80211/Kconfig. Dave, how do you prefer this? -- Gustavo F. Padovan http://profusion.mobi -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
