RE: [PATCH v1 1/3] Bluetooth: btintel_pcie: Print Firmware Sequencer information

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Paul,

Thanks for your comments.

>-----Original Message-----
>From: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
>Sent: Thursday, May 16, 2024 6:31 PM
>To: K, Kiran <kiran.k@xxxxxxxxx>
>Cc: Srivatsa, Ravishankar <ravishankar.srivatsa@xxxxxxxxx>; Tumkur Narayan,
>Chethan <chethan.tumkur.narayan@xxxxxxxxx>; Satija, Vijay
><vijay.satija@xxxxxxxxx>; linux-bluetooth@xxxxxxxxxxxxxxx
>Subject: Re: [PATCH v1 1/3] Bluetooth: btintel_pcie: Print Firmware Sequencer
>information
>
>Dear Kiran,
>
>
>Am 16.05.24 um 14:39 schrieb Kiran K:
>> From: Kiran <kiran.k@xxxxxxxxx>
>
>Should this be Kiran K?
>
Yes. I will fix it. Looks like the machine where this fix is done is not configured properly. ☹

>> Firmware sequencer (FSEQ) is a common code shared across Bluetooth and
>> Wifi. Printing FSEQ will help to debug if there is any mismatch
>
>So, make `btintel_print_fseq_info()` public, and call it in btintel_pci.
>
>> between Bluetooth and Wifi FSEQ.
>
>Please paste one example message.

I will include commit message in v3 version.
>
>> Signed-off-by: Kiran <kiran.k@xxxxxxxxx>
>> ---
>>   drivers/bluetooth/btintel.c      | 3 ++-
>>   drivers/bluetooth/btintel.h      | 5 +++++
>>   drivers/bluetooth/btintel_pcie.c | 2 ++
>>   3 files changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
>> index 0c855c3ee1c1..2c434ff9c47c 100644
>> --- a/drivers/bluetooth/btintel.c
>> +++ b/drivers/bluetooth/btintel.c
>> @@ -2713,7 +2713,7 @@ void btintel_set_msft_opcode(struct hci_dev
>*hdev, u8 hw_variant)
>>   }
>>   EXPORT_SYMBOL_GPL(btintel_set_msft_opcode);
>>
>> -static void btintel_print_fseq_info(struct hci_dev *hdev)
>> +void btintel_print_fseq_info(struct hci_dev *hdev)
>>   {
>>   	struct sk_buff *skb;
>>   	u8 *p;
>> @@ -2825,6 +2825,7 @@ static void btintel_print_fseq_info(struct
>> hci_dev *hdev)
>>
>>   	kfree_skb(skb);
>>   }
>> +EXPORT_SYMBOL_GPL(btintel_print_fseq_info);
>>
>>   static int btintel_setup_combined(struct hci_dev *hdev)
>>   {
>> diff --git a/drivers/bluetooth/btintel.h b/drivers/bluetooth/btintel.h
>> index b5fea735e260..796953547932 100644
>> --- a/drivers/bluetooth/btintel.h
>> +++ b/drivers/bluetooth/btintel.h
>> @@ -244,6 +244,7 @@ int btintel_bootloader_setup_tlv(struct hci_dev
>*hdev,
>>   				 struct intel_version_tlv *ver);
>>   int btintel_shutdown_combined(struct hci_dev *hdev);
>>   void btintel_hw_error(struct hci_dev *hdev, u8 code);
>> +void btintel_print_fseq_info(struct hci_dev *hdev);
>>   #else
>>
>>   static inline int btintel_check_bdaddr(struct hci_dev *hdev) @@
>> -373,4 +374,8 @@ static inline int btintel_shutdown_combined(struct
>hci_dev *hdev)
>>   static inline void btintel_hw_error(struct hci_dev *hdev, u8 code)
>>   {
>>   }
>> +
>> +static void btintel_print_fseq_info(struct hci_dev *hdev) { }
>>   #endif
>> diff --git a/drivers/bluetooth/btintel_pcie.c
>> b/drivers/bluetooth/btintel_pcie.c
>> index 5b6805d87fcf..8d282ee2322c 100644
>> --- a/drivers/bluetooth/btintel_pcie.c
>> +++ b/drivers/bluetooth/btintel_pcie.c
>> @@ -1197,9 +1197,11 @@ static int btintel_pcie_setup(struct hci_dev *hdev)
>>   		bt_dev_err(hdev, "Unsupported Intel hw variant (%u)",
>>   			   INTEL_HW_VARIANT(ver_tlv.cnvi_bt));
>>   		err = -EINVAL;
>> +		goto exit_error;
>>   		break;
>>   	}
>>
>> +	btintel_print_fseq_info(hdev);
>>   exit_error:
>>   	kfree_skb(skb);
>>
>
>
>Kind regards,
>
>Paul

Thanks,
Kiran





[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux