Re: [PATCH] bluetooth: btintel_pcie: nonsense error recording in irq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[Cc: +Kiran]

Dear Oliver,


Thank you for the patch. I have two minor comments. Could you please word the summary as a statement by adding a verb (in imperative mood). Maybe:

> Fix nonsense …

or

> Remove unused `ret` assignment

Am 16.05.24 um 06:50 schrieb Oliver Neukum:
Either you return an error or you ignore it.
Recording it but then overwriting it makes no sense.
It’d be great if you added a Fixes: tag.

Signed-off-by: Oliver Neukum <oneukum@xxxxxxxx>
---
  drivers/bluetooth/btintel_pcie.c | 8 ++------
  1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
index 590c188a4bb3..c507422d6b1b 100644
--- a/drivers/bluetooth/btintel_pcie.c
+++ b/drivers/bluetooth/btintel_pcie.c
@@ -498,19 +498,15 @@ static int btintel_pcie_submit_rx_work(struct btintel_pcie_data *data, u8 status
  	rfh_hdr = buf;
len = rfh_hdr->packet_len;
-	if (len <= 0) {
-		ret = -EINVAL;
+	if (len <= 0)
  		goto resubmit;
-	}
/* Remove RFH header */
  	buf += sizeof(*rfh_hdr);
skb = alloc_skb(len, GFP_ATOMIC);
-	if (!skb) {
-		ret = -ENOMEM;
+	if (!skb)
  		goto resubmit;
-	}
skb_put_data(skb, buf, len);
  	skb_queue_tail(&data->rx_skb_q, skb);


Kind regards,

Paul




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux