RE: ASHA plugin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=851633

---Test result---

Test Summary:
CheckPatch                    FAIL      3.12 seconds
GitLint                       PASS      1.63 seconds
BuildEll                      PASS      24.29 seconds
BluezMake                     FAIL      85.07 seconds
MakeCheck                     FAIL      1965.36 seconds
MakeDistcheck                 FAIL      57.75 seconds
CheckValgrind                 FAIL      64.62 seconds
CheckSmatch                   FAIL      165.45 seconds
bluezmakeextell               FAIL      65.35 seconds
IncrementalBuild              FAIL      1553.75 seconds
ScanBuild                     FAIL      695.26 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,1/5] profiles: Add initial code for an ASHA plugin
WARNING:LONG_LINE: line length of 86 exceeds 80 columns
#352: FILE: profiles/audio/asha.c:187:
+	err = setsockopt(fd, SOL_BLUETOOTH, BT_RCVMTU, &opts.imtu, sizeof(opts.imtu));

WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#361: FILE: profiles/audio/asha.c:196:
+		error("Could not connect L2CAP CoC socket: %s", strerror(errno));

WARNING:TYPO_SPELLING: 'errror' may be misspelled - perhaps 'error'?
#492: FILE: profiles/audio/asha.c:327:
+		DBG("Reading PSM failed with ATT errror: %u", att_ecode);
 		                                 ^^^^^^

WARNING:TYPO_SPELLING: 'errror' may be misspelled - perhaps 'error'?
#515: FILE: profiles/audio/asha.c:350:
+		DBG("Reading ROPs failed with ATT errror: %u", att_ecode);
 		                                  ^^^^^^

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line (or did you mean 'else if'?)
#595: FILE: profiles/audio/asha.c:430:
+	} if (uuid_cmp(ASHA_CHRC_READ_ONLY_PROPERTIES_UUID, &uuid)) {

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line (or did you mean 'else if'?)
#599: FILE: profiles/audio/asha.c:434:
+	} if (uuid_cmp(ASHA_CHRC_AUDIO_CONTROL_POINT_UUID, &uuid)) {

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line (or did you mean 'else if'?)
#602: FILE: profiles/audio/asha.c:437:
+	} if (uuid_cmp(ASHA_CHRC_AUDIO_STATUS_UUID, &uuid)) {

WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#616: FILE: profiles/audio/asha.c:451:
+static void foreach_asha_service(struct gatt_db_attribute *attr, void *user_data)

WARNING:RETURN_VOID: void function return statements are not generally useful
#809: FILE: profiles/audio/asha.c:644:
+	return;
+}

WARNING:NEW_TYPEDEFS: do not add new typedefs
#949: FILE: profiles/audio/asha.h:17:
+typedef enum {

ERROR:FUNCTION_WITHOUT_ARGS: Bad function definition - const struct media_endpoint *media_endpoint_get_asha() should probably be const struct media_endpoint *media_endpoint_get_asha(void)
#1026: FILE: profiles/audio/media.c:3411:
+const struct media_endpoint *media_endpoint_get_asha()

ERROR:FUNCTION_WITHOUT_ARGS: Bad function definition - const struct media_endpoint *media_endpoint_get_asha() should probably be const struct media_endpoint *media_endpoint_get_asha(void)
#1047: FILE: profiles/audio/media.h:28:
+const struct media_endpoint *media_endpoint_get_asha();

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#1130: FILE: profiles/audio/transport.c:1753:
+	switch (asha_device_get_state(asha)) {
+		case ASHA_STOPPED:
[...]
+		case ASHA_STARTING:
[...]
+		case ASHA_STARTED:
[...]
+		case ASHA_STOPPING:

WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#1135: FILE: profiles/audio/transport.c:1758:
+			transport_set_state(transport, TRANSPORT_STATE_REQUESTING);

WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#1141: FILE: profiles/audio/transport.c:1764:
+			transport_set_state(transport, TRANSPORT_STATE_SUSPENDING);

/github/workspace/src/src/13658883.patch total: 6 errors, 9 warnings, 1089 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13658883.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


[BlueZ,2/5] asha: Implement volume on transport
WARNING:TYPO_SPELLING: 'errror' may be misspelled - perhaps 'error'?
#191: FILE: profiles/audio/asha.c:450:
+		DBG("Reading volume failed with ATT errror: %u", att_ecode);
 		                                    ^^^^^^

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line (or did you mean 'else if'?)
#227: FILE: profiles/audio/asha.c:498:
+	} if (uuid_cmp(ASHA_CHRC_VOLUME_UUID, &uuid)) {

/github/workspace/src/src/13658879.patch total: 1 errors, 1 warnings, 190 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13658879.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


[BlueZ,3/5] test: Add a script to test ASHA
ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
#104: FILE: test/simple-asha

/github/workspace/src/src/13658880.patch total: 1 errors, 0 warnings, 158 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13658880.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: BluezMake - FAIL
Desc: Build BlueZ
Output:

tools/mgmt-tester.c: In function ‘main’:
tools/mgmt-tester.c:12725:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
12725 | int main(int argc, char *argv[])
      |     ^~~~
profiles/audio/asha.c: In function ‘asha_state_reset’:
profiles/audio/asha.c:122:2: error: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Werror=implicit-function-declaration]
  122 |  close(asha->fd);
      |  ^~~~~
      |  pclose
In file included from profiles/audio/asha.c:35:
profiles/audio/asha.c: In function ‘asha_connect_socket’:
profiles/audio/asha.c:167:57: error: ‘errno’ undeclared (first use in this function)
  167 |   error("Could not open L2CAP CoC socket: %s", strerror(errno));
      |                                                         ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
   62 |  btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
      |                                                           ^~~
profiles/audio/asha.c:49:1: note: ‘errno’ is defined in header ‘<errno.h>’; did you forget to ‘#include <errno.h>’?
   48 | #include "l2cap.h"
  +++ |+#include <errno.h>
   49 | 
In file included from profiles/audio/asha.c:35:
profiles/audio/asha.c:167:57: note: each undeclared identifier is reported only once for each function it appears in
  167 |   error("Could not open L2CAP CoC socket: %s", strerror(errno));
      |                                                         ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
   62 |  btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
      |                                                           ^~~
profiles/audio/asha.c:161:19: error: unused variable ‘ret’ [-Werror=unused-variable]
  161 |  int fd = 0, err, ret = 0;
      |                   ^~~
profiles/audio/asha.c: At top level:
profiles/audio/asha.c:411:6: error: no previous declaration for ‘audio_status_notify’ [-Werror=missing-declarations]
  411 | void audio_status_notify(uint16_t value_handle, const uint8_t *value,
      |      ^~~~~~~~~~~~~~~~~~~
profiles/audio/asha.c:464:6: error: no previous declaration for ‘volume_notify’ [-Werror=missing-declarations]
  464 | void volume_notify(uint16_t value_handle, const uint8_t *value,
      |      ^~~~~~~~~~~~~
profiles/audio/asha.c: In function ‘asha_source_disconnect’:
profiles/audio/asha.c:784:12: error: unused variable ‘asha_uuid’ [-Werror=unused-variable]
  784 |  bt_uuid_t asha_uuid;
      |            ^~~~~~~~~
profiles/audio/asha.c:782:25: error: unused variable ‘client’ [-Werror=unused-variable]
  782 |  struct bt_gatt_client *client = btd_device_get_gatt_client(device);
      |                         ^~~~~~
profiles/audio/asha.c:781:18: error: unused variable ‘db’ [-Werror=unused-variable]
  781 |  struct gatt_db *db = btd_device_get_gatt_db(device);
      |                  ^~
At top level:
profiles/audio/asha.c:535:21: error: ‘asha_set_configuration’ defined but not used [-Werror=unused-function]
  535 | static DBusMessage *asha_set_configuration(DBusConnection *conn,
      |                     ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10691: profiles/audio/bluetoothd-asha.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4656: all] Error 2
##############################
Test: MakeCheck - FAIL
Desc: Run Bluez Make Check
Output:

unit/test-avdtp.c: In function ‘main’:
unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
  766 | int main(int argc, char *argv[])
      |     ^~~~
unit/test-avrcp.c: In function ‘main’:
unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
  989 | int main(int argc, char *argv[])
      |     ^~~~
profiles/audio/asha.c: In function ‘asha_state_reset’:
profiles/audio/asha.c:122:2: error: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Werror=implicit-function-declaration]
  122 |  close(asha->fd);
      |  ^~~~~
      |  pclose
In file included from profiles/audio/asha.c:35:
profiles/audio/asha.c: In function ‘asha_connect_socket’:
profiles/audio/asha.c:167:57: error: ‘errno’ undeclared (first use in this function)
  167 |   error("Could not open L2CAP CoC socket: %s", strerror(errno));
      |                                                         ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
   62 |  btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
      |                                                           ^~~
profiles/audio/asha.c:49:1: note: ‘errno’ is defined in header ‘<errno.h>’; did you forget to ‘#include <errno.h>’?
   48 | #include "l2cap.h"
  +++ |+#include <errno.h>
   49 | 
In file included from profiles/audio/asha.c:35:
profiles/audio/asha.c:167:57: note: each undeclared identifier is reported only once for each function it appears in
  167 |   error("Could not open L2CAP CoC socket: %s", strerror(errno));
      |                                                         ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
   62 |  btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
      |                                                           ^~~
profiles/audio/asha.c:161:19: error: unused variable ‘ret’ [-Werror=unused-variable]
  161 |  int fd = 0, err, ret = 0;
      |                   ^~~
profiles/audio/asha.c: At top level:
profiles/audio/asha.c:411:6: error: no previous declaration for ‘audio_status_notify’ [-Werror=missing-declarations]
  411 | void audio_status_notify(uint16_t value_handle, const uint8_t *value,
      |      ^~~~~~~~~~~~~~~~~~~
profiles/audio/asha.c:464:6: error: no previous declaration for ‘volume_notify’ [-Werror=missing-declarations]
  464 | void volume_notify(uint16_t value_handle, const uint8_t *value,
      |      ^~~~~~~~~~~~~
profiles/audio/asha.c: In function ‘asha_source_disconnect’:
profiles/audio/asha.c:784:12: error: unused variable ‘asha_uuid’ [-Werror=unused-variable]
  784 |  bt_uuid_t asha_uuid;
      |            ^~~~~~~~~
profiles/audio/asha.c:782:25: error: unused variable ‘client’ [-Werror=unused-variable]
  782 |  struct bt_gatt_client *client = btd_device_get_gatt_client(device);
      |                         ^~~~~~
profiles/audio/asha.c:781:18: error: unused variable ‘db’ [-Werror=unused-variable]
  781 |  struct gatt_db *db = btd_device_get_gatt_db(device);
      |                  ^~
At top level:
profiles/audio/asha.c:535:21: error: ‘asha_set_configuration’ defined but not used [-Werror=unused-function]
  535 | static DBusMessage *asha_set_configuration(DBusConnection *conn,
      |                     ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10691: profiles/audio/bluetoothd-asha.o] Error 1
make: *** [Makefile:12209: check] Error 2
##############################
Test: MakeDistcheck - FAIL
Desc: Run Bluez Make Distcheck
Output:

Package cups was not found in the pkg-config search path.
Perhaps you should add the directory containing `cups.pc'
to the PKG_CONFIG_PATH environment variable
No package 'cups' found
../../profiles/audio/asha.c:47:10: fatal error: asha.h: No such file or directory
   47 | #include "asha.h"
      |          ^~~~~~~~
compilation terminated.
make[2]: *** [Makefile:10691: profiles/audio/bluetoothd-asha.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:4656: all] Error 2
make: *** [Makefile:12130: distcheck] Error 1
##############################
Test: CheckValgrind - FAIL
Desc: Run Bluez Make Check with Valgrind
Output:

tools/mgmt-tester.c: In function ‘main’:
tools/mgmt-tester.c:12725:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
12725 | int main(int argc, char *argv[])
      |     ^~~~
profiles/audio/asha.c: In function ‘asha_state_reset’:
profiles/audio/asha.c:122:2: error: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Werror=implicit-function-declaration]
  122 |  close(asha->fd);
      |  ^~~~~
      |  pclose
In file included from profiles/audio/asha.c:35:
profiles/audio/asha.c: In function ‘asha_connect_socket’:
profiles/audio/asha.c:167:57: error: ‘errno’ undeclared (first use in this function)
  167 |   error("Could not open L2CAP CoC socket: %s", strerror(errno));
      |                                                         ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
   62 |  btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
      |                                                           ^~~
profiles/audio/asha.c:49:1: note: ‘errno’ is defined in header ‘<errno.h>’; did you forget to ‘#include <errno.h>’?
   48 | #include "l2cap.h"
  +++ |+#include <errno.h>
   49 | 
In file included from profiles/audio/asha.c:35:
profiles/audio/asha.c:167:57: note: each undeclared identifier is reported only once for each function it appears in
  167 |   error("Could not open L2CAP CoC socket: %s", strerror(errno));
      |                                                         ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
   62 |  btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
      |                                                           ^~~
profiles/audio/asha.c:161:19: error: unused variable ‘ret’ [-Werror=unused-variable]
  161 |  int fd = 0, err, ret = 0;
      |                   ^~~
profiles/audio/asha.c: At top level:
profiles/audio/asha.c:411:6: error: no previous declaration for ‘audio_status_notify’ [-Werror=missing-declarations]
  411 | void audio_status_notify(uint16_t value_handle, const uint8_t *value,
      |      ^~~~~~~~~~~~~~~~~~~
profiles/audio/asha.c:464:6: error: no previous declaration for ‘volume_notify’ [-Werror=missing-declarations]
  464 | void volume_notify(uint16_t value_handle, const uint8_t *value,
      |      ^~~~~~~~~~~~~
profiles/audio/asha.c: In function ‘asha_source_disconnect’:
profiles/audio/asha.c:784:12: error: unused variable ‘asha_uuid’ [-Werror=unused-variable]
  784 |  bt_uuid_t asha_uuid;
      |            ^~~~~~~~~
profiles/audio/asha.c:782:25: error: unused variable ‘client’ [-Werror=unused-variable]
  782 |  struct bt_gatt_client *client = btd_device_get_gatt_client(device);
      |                         ^~~~~~
profiles/audio/asha.c:781:18: error: unused variable ‘db’ [-Werror=unused-variable]
  781 |  struct gatt_db *db = btd_device_get_gatt_db(device);
      |                  ^~
At top level:
profiles/audio/asha.c:535:21: error: ‘asha_set_configuration’ defined but not used [-Werror=unused-function]
  535 | static DBusMessage *asha_set_configuration(DBusConnection *conn,
      |                     ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10691: profiles/audio/bluetoothd-asha.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:12209: check] Error 2
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:

src/shared/crypto.c:271:21: warning: Variable length array is used.
src/shared/crypto.c:272:23: warning: Variable length array is used.
src/shared/gatt-helpers.c:768:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:830:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1323:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1354:23: warning: Variable length array is used.
src/shared/gatt-server.c:278:25: warning: Variable length array is used.
src/shared/gatt-server.c:621:25: warning: Variable length array is used.
src/shared/gatt-server.c:720:25: warning: Variable length array is used.
src/shared/bap.c:282:25: warning: array of flexible structures
src/shared/bap.c: note: in included file:
./src/shared/ascs.h:88:25: warning: array of flexible structures
src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):
/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function'
/usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction'
/usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction'
/usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction'
src/shared/crypto.c:271:21: warning: Variable length array is used.
src/shared/crypto.c:272:23: warning: Variable length array is used.
src/shared/gatt-helpers.c:768:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:830:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1323:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1354:23: warning: Variable length array is used.
src/shared/gatt-server.c:278:25: warning: Variable length array is used.
src/shared/gatt-server.c:621:25: warning: Variable length array is used.
src/shared/gatt-server.c:720:25: warning: Variable length array is used.
src/shared/bap.c:282:25: warning: array of flexible structures
src/shared/bap.c: note: in included file:
./src/shared/ascs.h:88:25: warning: array of flexible structures
src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):
/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function'
/usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction'
/usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction'
/usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction'
tools/mesh-cfgtest.c:1453:17: warning: unknown escape sequence: '\%'
tools/sco-tester.c: note: in included file:
./lib/bluetooth.h:219:15: warning: array of flexible structures
./lib/bluetooth.h:224:31: warning: array of flexible structures
tools/bneptest.c:634:39: warning: unknown escape sequence: '\%'
tools/seq2bseq.c:57:26: warning: Variable length array is used.
tools/obex-client-tool.c: note: in included file (through /usr/include/readline/readline.h):
/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function'
/usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction'
/usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction'
/usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction'
android/avctp.c:505:34: warning: Variable length array is used.
android/avctp.c:556:34: warning: Variable length array is used.
unit/test-avrcp.c:373:26: warning: Variable length array is used.
unit/test-avrcp.c:398:26: warning: Variable length array is used.
unit/test-avrcp.c:414:24: warning: Variable length array is used.
android/avrcp-lib.c:1085:34: warning: Variable length array is used.
android/avrcp-lib.c:1583:34: warning: Variable length array is used.
android/avrcp-lib.c:1612:34: warning: Variable length array is used.
android/avrcp-lib.c:1638:34: warning: Variable length array is used.
profiles/audio/asha.c: In function ‘asha_state_reset’:
profiles/audio/asha.c:122:2: error: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Werror=implicit-function-declaration]
  122 |  close(asha->fd);
      |  ^~~~~
      |  pclose
In file included from profiles/audio/asha.c:35:
profiles/audio/asha.c: In function ‘asha_connect_socket’:
profiles/audio/asha.c:167:57: error: ‘errno’ undeclared (first use in this function)
  167 |   error("Could not open L2CAP CoC socket: %s", strerror(errno));
      |                                                         ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
   62 |  btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
      |                                                           ^~~
profiles/audio/asha.c:49:1: note: ‘errno’ is defined in header ‘<errno.h>’; did you forget to ‘#include <errno.h>’?
   48 | #include "l2cap.h"
  +++ |+#include <errno.h>
   49 | 
In file included from profiles/audio/asha.c:35:
profiles/audio/asha.c:167:57: note: each undeclared identifier is reported only once for each function it appears in
  167 |   error("Could not open L2CAP CoC socket: %s", strerror(errno));
      |                                                         ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
   62 |  btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
      |                                                           ^~~
profiles/audio/asha.c:161:19: error: unused variable ‘ret’ [-Werror=unused-variable]
  161 |  int fd = 0, err, ret = 0;
      |                   ^~~
profiles/audio/asha.c: At top level:
profiles/audio/asha.c:411:6: error: no previous declaration for ‘audio_status_notify’ [-Werror=missing-declarations]
  411 | void audio_status_notify(uint16_t value_handle, const uint8_t *value,
      |      ^~~~~~~~~~~~~~~~~~~
profiles/audio/asha.c:464:6: error: no previous declaration for ‘volume_notify’ [-Werror=missing-declarations]
  464 | void volume_notify(uint16_t value_handle, const uint8_t *value,
      |      ^~~~~~~~~~~~~
profiles/audio/asha.c: In function ‘asha_source_disconnect’:
profiles/audio/asha.c:784:12: error: unused variable ‘asha_uuid’ [-Werror=unused-variable]
  784 |  bt_uuid_t asha_uuid;
      |            ^~~~~~~~~
profiles/audio/asha.c:782:25: error: unused variable ‘client’ [-Werror=unused-variable]
  782 |  struct bt_gatt_client *client = btd_device_get_gatt_client(device);
      |                         ^~~~~~
profiles/audio/asha.c:781:18: error: unused variable ‘db’ [-Werror=unused-variable]
  781 |  struct gatt_db *db = btd_device_get_gatt_db(device);
      |                  ^~
At top level:
profiles/audio/asha.c:535:21: error: ‘asha_set_configuration’ defined but not used [-Werror=unused-function]
  535 | static DBusMessage *asha_set_configuration(DBusConnection *conn,
      |                     ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10691: profiles/audio/bluetoothd-asha.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4656: all] Error 2
##############################
Test: bluezmakeextell - FAIL
Desc: Build Bluez with External ELL
Output:

profiles/audio/asha.c: In function ‘asha_state_reset’:
profiles/audio/asha.c:122:2: error: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Werror=implicit-function-declaration]
  122 |  close(asha->fd);
      |  ^~~~~
      |  pclose
In file included from profiles/audio/asha.c:35:
profiles/audio/asha.c: In function ‘asha_connect_socket’:
profiles/audio/asha.c:167:57: error: ‘errno’ undeclared (first use in this function)
  167 |   error("Could not open L2CAP CoC socket: %s", strerror(errno));
      |                                                         ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
   62 |  btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
      |                                                           ^~~
profiles/audio/asha.c:49:1: note: ‘errno’ is defined in header ‘<errno.h>’; did you forget to ‘#include <errno.h>’?
   48 | #include "l2cap.h"
  +++ |+#include <errno.h>
   49 | 
In file included from profiles/audio/asha.c:35:
profiles/audio/asha.c:167:57: note: each undeclared identifier is reported only once for each function it appears in
  167 |   error("Could not open L2CAP CoC socket: %s", strerror(errno));
      |                                                         ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
   62 |  btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
      |                                                           ^~~
profiles/audio/asha.c:161:19: error: unused variable ‘ret’ [-Werror=unused-variable]
  161 |  int fd = 0, err, ret = 0;
      |                   ^~~
profiles/audio/asha.c: At top level:
profiles/audio/asha.c:411:6: error: no previous declaration for ‘audio_status_notify’ [-Werror=missing-declarations]
  411 | void audio_status_notify(uint16_t value_handle, const uint8_t *value,
      |      ^~~~~~~~~~~~~~~~~~~
profiles/audio/asha.c:464:6: error: no previous declaration for ‘volume_notify’ [-Werror=missing-declarations]
  464 | void volume_notify(uint16_t value_handle, const uint8_t *value,
      |      ^~~~~~~~~~~~~
profiles/audio/asha.c: In function ‘asha_source_disconnect’:
profiles/audio/asha.c:784:12: error: unused variable ‘asha_uuid’ [-Werror=unused-variable]
  784 |  bt_uuid_t asha_uuid;
      |            ^~~~~~~~~
profiles/audio/asha.c:782:25: error: unused variable ‘client’ [-Werror=unused-variable]
  782 |  struct bt_gatt_client *client = btd_device_get_gatt_client(device);
      |                         ^~~~~~
profiles/audio/asha.c:781:18: error: unused variable ‘db’ [-Werror=unused-variable]
  781 |  struct gatt_db *db = btd_device_get_gatt_db(device);
      |                  ^~
At top level:
profiles/audio/asha.c:535:21: error: ‘asha_set_configuration’ defined but not used [-Werror=unused-function]
  535 | static DBusMessage *asha_set_configuration(DBusConnection *conn,
      |                     ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10691: profiles/audio/bluetoothd-asha.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4656: all] Error 2
##############################
Test: IncrementalBuild - FAIL
Desc: Incremental build with the patches in the series
Output:
[BlueZ,1/5] profiles: Add initial code for an ASHA plugin

tools/mgmt-tester.c: In function ‘main’:
tools/mgmt-tester.c:12725:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
12725 | int main(int argc, char *argv[])
      |     ^~~~
unit/test-avdtp.c: In function ‘main’:
unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
  766 | int main(int argc, char *argv[])
      |     ^~~~
unit/test-avrcp.c: In function ‘main’:
unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
  989 | int main(int argc, char *argv[])
      |     ^~~~
profiles/audio/asha.c: In function ‘asha_state_reset’:
profiles/audio/asha.c:113:2: error: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Werror=implicit-function-declaration]
  113 |  close(asha->fd);
      |  ^~~~~
      |  pclose
In file included from profiles/audio/asha.c:35:
profiles/audio/asha.c: In function ‘asha_connect_socket’:
profiles/audio/asha.c:158:57: error: ‘errno’ undeclared (first use in this function)
  158 |   error("Could not open L2CAP CoC socket: %s", strerror(errno));
      |                                                         ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
   62 |  btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
      |                                                           ^~~
profiles/audio/asha.c:49:1: note: ‘errno’ is defined in header ‘<errno.h>’; did you forget to ‘#include <errno.h>’?
   48 | #include "l2cap.h"
  +++ |+#include <errno.h>
   49 | 
In file included from profiles/audio/asha.c:35:
profiles/audio/asha.c:158:57: note: each undeclared identifier is reported only once for each function it appears in
  158 |   error("Could not open L2CAP CoC socket: %s", strerror(errno));
      |                                                         ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
   62 |  btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
      |                                                           ^~~
profiles/audio/asha.c:152:19: error: unused variable ‘ret’ [-Werror=unused-variable]
  152 |  int fd = 0, err, ret = 0;
      |                   ^~~
profiles/audio/asha.c: At top level:
profiles/audio/asha.c:383:6: error: no previous declaration for ‘audio_status_notify’ [-Werror=missing-declarations]
  383 | void audio_status_notify(uint16_t value_handle, const uint8_t *value,
      |      ^~~~~~~~~~~~~~~~~~~
profiles/audio/asha.c: In function ‘asha_source_disconnect’:
profiles/audio/asha.c:710:12: error: unused variable ‘asha_uuid’ [-Werror=unused-variable]
  710 |  bt_uuid_t asha_uuid;
      |            ^~~~~~~~~
profiles/audio/asha.c:708:25: error: unused variable ‘client’ [-Werror=unused-variable]
  708 |  struct bt_gatt_client *client = btd_device_get_gatt_client(device);
      |                         ^~~~~~
profiles/audio/asha.c:707:18: error: unused variable ‘db’ [-Werror=unused-variable]
  707 |  struct gatt_db *db = btd_device_get_gatt_db(device);
      |                  ^~
At top level:
profiles/audio/asha.c:461:21: error: ‘asha_set_configuration’ defined but not used [-Werror=unused-function]
  461 | static DBusMessage *asha_set_configuration(DBusConnection *conn,
      |                     ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10691: profiles/audio/bluetoothd-asha.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4656: all] Error 2
##############################
Test: ScanBuild - FAIL
Desc: Run Scan Build
Output:

src/shared/gatt-client.c:451:21: warning: Use of memory after it is freed
        gatt_db_unregister(op->client->db, op->db_id);
                           ^~~~~~~~~~
src/shared/gatt-client.c:696:2: warning: Use of memory after it is freed
        discovery_op_complete(op, false, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:996:2: warning: Use of memory after it is freed
        discovery_op_complete(op, success, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1102:2: warning: Use of memory after it is freed
        discovery_op_complete(op, success, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1294:2: warning: Use of memory after it is freed
        discovery_op_complete(op, success, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1359:2: warning: Use of memory after it is freed
        discovery_op_complete(op, success, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1634:6: warning: Use of memory after it is freed
        if (read_db_hash(op)) {
            ^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1639:2: warning: Use of memory after it is freed
        discover_all(op);
        ^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2143:6: warning: Use of memory after it is freed
        if (read_db_hash(op)) {
            ^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2151:8: warning: Use of memory after it is freed
                                                        discovery_op_ref(op),
                                                        ^~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3240:2: warning: Use of memory after it is freed
        complete_write_long_op(req, success, 0, false);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3262:2: warning: Use of memory after it is freed
        request_unref(req);
        ^~~~~~~~~~~~~~~~~~
12 warnings generated.
src/shared/shell.c:1331:13: warning: Access to field 'options' results in a dereference of a null pointer (loaded from variable 'opt')
                        if (c != opt->options[index - offset].val) {
                                 ^~~~~~~~~~~~
1 warning generated.
src/shared/gatt-client.c:451:21: warning: Use of memory after it is freed
        gatt_db_unregister(op->client->db, op->db_id);
                           ^~~~~~~~~~
src/shared/gatt-client.c:696:2: warning: Use of memory after it is freed
        discovery_op_complete(op, false, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:996:2: warning: Use of memory after it is freed
        discovery_op_complete(op, success, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1102:2: warning: Use of memory after it is freed
        discovery_op_complete(op, success, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1294:2: warning: Use of memory after it is freed
        discovery_op_complete(op, success, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1359:2: warning: Use of memory after it is freed
        discovery_op_complete(op, success, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1634:6: warning: Use of memory after it is freed
        if (read_db_hash(op)) {
            ^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1639:2: warning: Use of memory after it is freed
        discover_all(op);
        ^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2143:6: warning: Use of memory after it is freed
        if (read_db_hash(op)) {
            ^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2151:8: warning: Use of memory after it is freed
                                                        discovery_op_ref(op),
                                                        ^~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3240:2: warning: Use of memory after it is freed
        complete_write_long_op(req, success, 0, false);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3262:2: warning: Use of memory after it is freed
        request_unref(req);
        ^~~~~~~~~~~~~~~~~~
12 warnings generated.
src/shared/shell.c:1331:13: warning: Access to field 'options' results in a dereference of a null pointer (loaded from variable 'opt')
                        if (c != opt->options[index - offset].val) {
                                 ^~~~~~~~~~~~
1 warning generated.
tools/hciattach.c:816:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
        if ((n = read_hci_event(fd, resp, 10)) < 0) {
             ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:864:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
        if ((n = read_hci_event(fd, resp, 4)) < 0) {
             ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:886:8: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
                if ((n = read_hci_event(fd, resp, 10)) < 0) {
                     ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:908:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
        if ((n = read_hci_event(fd, resp, 4)) < 0) {
             ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:929:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
        if ((n = read_hci_event(fd, resp, 4)) < 0) {
             ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:973:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
        if ((n = read_hci_event(fd, resp, 6)) < 0) {
             ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~
6 warnings generated.
src/oui.c:50:2: warning: Value stored to 'hwdb' is never read
        hwdb = udev_hwdb_unref(hwdb);
        ^      ~~~~~~~~~~~~~~~~~~~~~
src/oui.c:53:2: warning: Value stored to 'udev' is never read
        udev = udev_unref(udev);
        ^      ~~~~~~~~~~~~~~~~
2 warnings generated.
tools/hcidump.c:180:9: warning: Potential leak of memory pointed to by 'dp'
                                if (fds[i].fd == sock)
                                    ^~~
tools/hcidump.c:248:17: warning: Assigned value is garbage or undefined
                                dh->ts_sec  = htobl(frm.ts.tv_sec);
                                            ^ ~~~~~~~~~~~~~~~~~~~~
tools/hcidump.c:326:9: warning: 1st function call argument is an uninitialized value
                                if (be32toh(dp.flags) & 0x02) {
                                    ^~~~~~~~~~~~~~~~~
/usr/include/endian.h:46:22: note: expanded from macro 'be32toh'
#  define be32toh(x) __bswap_32 (x)
                     ^~~~~~~~~~~~~~
tools/hcidump.c:341:20: warning: 1st function call argument is an uninitialized value
                                frm.data_len = be32toh(dp.len);
                                               ^~~~~~~~~~~~~~~
/usr/include/endian.h:46:22: note: expanded from macro 'be32toh'
#  define be32toh(x) __bswap_32 (x)
                     ^~~~~~~~~~~~~~
tools/hcidump.c:346:14: warning: 1st function call argument is an uninitialized value
                                opcode = be32toh(dp.flags) & 0xffff;
                                         ^~~~~~~~~~~~~~~~~
/usr/include/endian.h:46:22: note: expanded from macro 'be32toh'
#  define be32toh(x) __bswap_32 (x)
                     ^~~~~~~~~~~~~~
tools/hcidump.c:384:17: warning: Assigned value is garbage or undefined
                        frm.data_len = btohs(dh.len);
                                     ^ ~~~~~~~~~~~~~
tools/hcidump.c:394:11: warning: Assigned value is garbage or undefined
                frm.len = frm.data_len;
                        ^ ~~~~~~~~~~~~
tools/hcidump.c:398:9: warning: 1st function call argument is an uninitialized value
                        ts = be64toh(ph.ts);
                             ^~~~~~~~~~~~~~
/usr/include/endian.h:51:22: note: expanded from macro 'be64toh'
#  define be64toh(x) __bswap_64 (x)
                     ^~~~~~~~~~~~~~
tools/hcidump.c:403:13: warning: 1st function call argument is an uninitialized value
                        frm.in = be32toh(dp.flags) & 0x01;
                                 ^~~~~~~~~~~~~~~~~
/usr/include/endian.h:46:22: note: expanded from macro 'be32toh'
#  define be32toh(x) __bswap_32 (x)
                     ^~~~~~~~~~~~~~
tools/hcidump.c:408:11: warning: Assigned value is garbage or undefined
                        frm.in = dh.in;
                               ^ ~~~~~
tools/hcidump.c:437:7: warning: Null pointer passed to 1st parameter expecting 'nonnull'
        fd = open(file, open_flags, 0644);
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
11 warnings generated.
tools/rfcomm.c:234:3: warning: Value stored to 'i' is never read
                i = execvp(cmdargv[0], cmdargv);
                ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/rfcomm.c:234:7: warning: Null pointer passed to 1st parameter expecting 'nonnull'
                i = execvp(cmdargv[0], cmdargv);
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/rfcomm.c:354:8: warning: Although the value stored to 'fd' is used in the enclosing expression, the value is never actually read from 'fd'
                if ((fd = open(devname, O_RDONLY | O_NOCTTY)) < 0) {
                     ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/rfcomm.c:497:14: warning: Assigned value is garbage or undefined
        req.channel = raddr.rc_channel;
                    ^ ~~~~~~~~~~~~~~~~
tools/rfcomm.c:515:8: warning: Although the value stored to 'fd' is used in the enclosing expression, the value is never actually read from 'fd'
                if ((fd = open(devname, O_RDONLY | O_NOCTTY)) < 0) {
                     ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5 warnings generated.
src/sdp-xml.c:126:10: warning: Assigned value is garbage or undefined
                buf[1] = data[i + 1];
                       ^ ~~~~~~~~~~~
src/sdp-xml.c:300:11: warning: Assigned value is garbage or undefined
                        buf[1] = data[i + 1];
                               ^ ~~~~~~~~~~~
src/sdp-xml.c:338:11: warning: Assigned value is garbage or undefined
                        buf[1] = data[i + 1];
                               ^ ~~~~~~~~~~~
3 warnings generated.
tools/ciptool.c:350:7: warning: 5th function call argument is an uninitialized value
        sk = do_connect(ctl, dev_id, &src, &dst, psm, (1 << CMTP_LOOPBACK));
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
tools/sdptool.c:941:26: warning: Result of 'malloc' is converted to a pointer of type 'uint32_t', which is incompatible with sizeof operand type 'int'
                        uint32_t *value_int = malloc(sizeof(int));
                        ~~~~~~~~~~            ^~~~~~ ~~~~~~~~~~~
tools/sdptool.c:980:4: warning: 1st function call argument is an uninitialized value
                        free(allocArray[i]);
                        ^~~~~~~~~~~~~~~~~~~
tools/sdptool.c:3777:2: warning: Potential leak of memory pointed to by 'si.name'
        return add_service(0, &si);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~
tools/sdptool.c:4112:4: warning: Potential leak of memory pointed to by 'context.svc'
                        return -1;
                        ^~~~~~~~~
4 warnings generated.
tools/avtest.c:225:5: warning: Value stored to 'len' is never read
                                len = write(sk, buf, 3);
                                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:235:5: warning: Value stored to 'len' is never read
                                len = write(sk, buf, 4);
                                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:244:5: warning: Value stored to 'len' is never read
                                len = write(sk, buf, 3);
                                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:258:5: warning: Value stored to 'len' is never read
                                len = write(sk, buf,
                                ^     ~~~~~~~~~~~~~~
tools/avtest.c:265:5: warning: Value stored to 'len' is never read
                                len = write(sk, buf,
                                ^     ~~~~~~~~~~~~~~
tools/avtest.c:272:5: warning: Value stored to 'len' is never read
                                len = write(sk, buf,
                                ^     ~~~~~~~~~~~~~~
tools/avtest.c:279:5: warning: Value stored to 'len' is never read
                                len = write(sk, buf,
                                ^     ~~~~~~~~~~~~~~
tools/avtest.c:291:5: warning: Value stored to 'len' is never read
                                len = write(sk, buf, 4);
                                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:295:5: warning: Value stored to 'len' is never read
                                len = write(sk, buf, 2);
                                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:304:5: warning: Value stored to 'len' is never read
                                len = write(sk, buf, 3);
                                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:308:5: warning: Value stored to 'len' is never read
                                len = write(sk, buf, 2);
                                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:317:5: warning: Value stored to 'len' is never read
                                len = write(sk, buf, 3);
                                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:324:5: warning: Value stored to 'len' is never read
                                len = write(sk, buf, 2);
                                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:346:5: warning: Value stored to 'len' is never read
                                len = write(sk, buf, 4);
                                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:350:5: warning: Value stored to 'len' is never read
                                len = write(sk, buf, 2);
                                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:359:5: warning: Value stored to 'len' is never read
                                len = write(sk, buf, 3);
                                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:363:5: warning: Value stored to 'len' is never read
                                len = write(sk, buf, 2);
                                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:376:5: warning: Value stored to 'len' is never read
                                len = write(sk, buf, 4);
                                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:380:5: warning: Value stored to 'len' is never read
                                len = write(sk, buf, 2);
                                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:387:4: warning: Value stored to 'len' is never read
                        len = write(sk, buf, 2);
                        ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:397:4: warning: Value stored to 'len' is never read
                        len = write(sk, buf, 2);
                        ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:562:3: warning: Value stored to 'len' is never read
                len = write(sk, buf, 2);
                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:570:3: warning: Value stored to 'len' is never read
                len = write(sk, buf, invalid ? 2 : 3);
                ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/avtest.c:584:3: warning: Value stored to 'len' is never read
                len = write(sk, buf, 4 + sizeof(media_transport));
                ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/avtest.c:597:3: warning: Value stored to 'len' is never read
                len = write(sk, buf, 3);
                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:607:3: warning: Value stored to 'len' is never read
                len = write(sk, buf, 3);
                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:619:3: warning: Value stored to 'len' is never read
                len = write(sk, buf, 3);
                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:634:3: warning: Value stored to 'len' is never read
                len = write(sk, buf, 3);
                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:646:3: warning: Value stored to 'len' is never read
                len = write(sk, buf, 3);
                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:655:3: warning: Value stored to 'len' is never read
                len = write(sk, buf, 3);
                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:662:3: warning: Value stored to 'len' is never read
                len = write(sk, buf, 2);
                ^     ~~~~~~~~~~~~~~~~~
tools/avtest.c:698:2: warning: Value stored to 'len' is never read
        len = write(sk, buf, AVCTP_HEADER_LENGTH + sizeof(play_pressed));
        ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
32 warnings generated.
tools/btproxy.c:836:15: warning: Null pointer passed to 1st parameter expecting 'nonnull'
                        tcp_port = atoi(optarg);
                                   ^~~~~~~~~~~~
tools/btproxy.c:839:8: warning: Null pointer passed to 1st parameter expecting 'nonnull'
                        if (strlen(optarg) > 3 && !strncmp(optarg, "hci", 3))
                            ^~~~~~~~~~~~~~
2 warnings generated.
tools/create-image.c:76:3: warning: Value stored to 'fd' is never read
                fd = -1;
                ^    ~~
tools/create-image.c:84:3: warning: Value stored to 'fd' is never read
                fd = -1;
                ^    ~~
tools/create-image.c:92:3: warning: Value stored to 'fd' is never read
                fd = -1;
                ^    ~~
tools/create-image.c:105:2: warning: Value stored to 'fd' is never read
        fd = -1;
        ^    ~~
4 warnings generated.
tools/btgatt-client.c:1824:2: warning: Value stored to 'argv' is never read
        argv += optind;
        ^       ~~~~~~
1 warning generated.
tools/btgatt-server.c:1212:2: warning: Value stored to 'argv' is never read
        argv -= optind;
        ^       ~~~~~~
1 warning generated.
tools/check-selftest.c:42:3: warning: Value stored to 'ptr' is never read
                ptr = fgets(result, sizeof(result), fp);
                ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
tools/gatt-service.c:294:2: warning: 2nd function call argument is an uninitialized value
        chr_write(chr, value, len);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
tools/obex-server-tool.c:133:13: warning: Null pointer passed to 1st parameter expecting 'nonnull'
        data->fd = open(name, O_WRONLY | O_CREAT | O_NOCTTY, 0600);
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/obex-server-tool.c:192:13: warning: Null pointer passed to 1st parameter expecting 'nonnull'
        data->fd = open(name, O_RDONLY | O_NOCTTY, 0);
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
tools/test-runner.c:945:2: warning: 2nd function call argument is an uninitialized value
        printf("Running command %s\n", cmdname ? cmdname : argv[0]);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
tools/btpclientctl.c:402:3: warning: Value stored to 'bit' is never read
                bit = 0;
                ^     ~
tools/btpclientctl.c:1655:2: warning: Null pointer passed to 2nd parameter expecting 'nonnull'
        memcpy(cp->data, ad_data, ad_len);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
src/sdpd-request.c:211:13: warning: Result of 'malloc' is converted to a pointer of type 'char', which is incompatible with sizeof operand type 'uint16_t'
                                pElem = malloc(sizeof(uint16_t));
                                        ^~~~~~ ~~~~~~~~~~~~~~~~
src/sdpd-request.c:239:13: warning: Result of 'malloc' is converted to a pointer of type 'char', which is incompatible with sizeof operand type 'uint32_t'
                                pElem = malloc(sizeof(uint32_t));
                                        ^~~~~~ ~~~~~~~~~~~~~~~~
2 warnings generated.
android/avrcp-lib.c:1968:3: warning: 1st function call argument is an uninitialized value
                g_free(text[i]);
                ^~~~~~~~~~~~~~~
1 warning generated.
profiles/health/hdp.c:644:3: warning: Use of memory after it is freed
                hdp_tmp_dc_data_unref(dc_data);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
profiles/health/hdp.c:800:19: warning: Use of memory after it is freed
                path = g_strdup(chan->path);
                                ^~~~~~~~~~
profiles/health/hdp.c:1779:6: warning: Use of memory after it is freed
                                        hdp_tmp_dc_data_ref(hdp_conn),
                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
profiles/health/hdp.c:1836:30: warning: Use of memory after it is freed
        reply = g_dbus_create_error(data->msg, ERROR_INTERFACE ".HealthError",
                                    ^~~~~~~~~
4 warnings generated.
profiles/health/hdp_util.c:1052:2: warning: Use of memory after it is freed
        conn_data->func(conn_data->data, gerr);
        ^~~~~~~~~~~~~~~
1 warning generated.
profiles/audio/asha.c: In function ‘asha_state_reset’:
profiles/audio/asha.c:113:2: error: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Werror=implicit-function-declaration]
  113 |  close(asha->fd);
      |  ^~~~~
      |  pclose
In file included from profiles/audio/asha.c:35:
profiles/audio/asha.c: In function ‘asha_connect_socket’:
profiles/audio/asha.c:158:57: error: ‘errno’ undeclared (first use in this function)
  158 |   error("Could not open L2CAP CoC socket: %s", strerror(errno));
      |                                                         ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
   62 |  btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
      |                                                           ^~~
profiles/audio/asha.c:49:1: note: ‘errno’ is defined in header ‘<errno.h>’; did you forget to ‘#include <errno.h>’?
   48 | #include "l2cap.h"
  +++ |+#include <errno.h>
   49 | 
In file included from profiles/audio/asha.c:35:
profiles/audio/asha.c:158:57: note: each undeclared identifier is reported only once for each function it appears in
  158 |   error("Could not open L2CAP CoC socket: %s", strerror(errno));
      |                                                         ^~~~~
./src/log.h:62:59: note: in definition of macro ‘error’
   62 |  btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg)
      |                                                           ^~~
profiles/audio/asha.c:152:19: error: unused variable ‘ret’ [-Werror=unused-variable]
  152 |  int fd = 0, err, ret = 0;
      |                   ^~~
profiles/audio/asha.c: At top level:
profiles/audio/asha.c:383:6: error: no previous declaration for ‘audio_status_notify’ [-Werror=missing-declarations]
  383 | void audio_status_notify(uint16_t value_handle, const uint8_t *value,
      |      ^~~~~~~~~~~~~~~~~~~
profiles/audio/asha.c: In function ‘asha_source_disconnect’:
profiles/audio/asha.c:710:12: error: unused variable ‘asha_uuid’ [-Werror=unused-variable]
  710 |  bt_uuid_t asha_uuid;
      |            ^~~~~~~~~
profiles/audio/asha.c:708:25: error: unused variable ‘client’ [-Werror=unused-variable]
  708 |  struct bt_gatt_client *client = btd_device_get_gatt_client(device);
      |                         ^~~~~~
profiles/audio/asha.c:707:18: error: unused variable ‘db’ [-Werror=unused-variable]
  707 |  struct gatt_db *db = btd_device_get_gatt_db(device);
      |                  ^~
At top level:
profiles/audio/asha.c:461:21: error: ‘asha_set_configuration’ defined but not used [-Werror=unused-function]
  461 | static DBusMessage *asha_set_configuration(DBusConnection *conn,
      |                     ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10691: profiles/audio/bluetoothd-asha.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4656: all] Error 2


---
Regards,
Linux Bluetooth


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux