Hi Bartosz,
On Fri, Apr 26, 2024 at 10:37 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
>
> On Wed, 24 Apr 2024 17:40:27 +0200, patchwork-bot+bluetooth@xxxxxxxxxx said:
> > Hello:
> >
> > This patch was applied to bluetooth/bluetooth-next.git (master)
> > by Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>:
> >
> > On Wed, 24 Apr 2024 14:29:32 +0200 you wrote:
> >> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >>
> >> Any return value from gpiod_get_optional() other than a pointer to a
> >> GPIO descriptor or a NULL-pointer is an error and the driver should
> >> abort probing. That being said: commit 56d074d26c58 ("Bluetooth: hci_qca:
> >> don't use IS_ERR_OR_NULL() with gpiod_get_optional()") no longer sets
> >> power_ctrl_enabled on NULL-pointer returned by
> >> devm_gpiod_get_optional(). Restore this behavior but bail-out on errors.
> >> While at it: also bail-out on error returned when trying to get the
> >> "swctrl" GPIO.
> >>
> >> [...]
> >
> > Here is the summary with links:
> > - [v2] Bluetooth: qca: set power_ctrl_enabled on NULL returned by gpiod_get_optional()
> > https://git.kernel.org/bluetooth/bluetooth-next/c/48a9e64a533b
> >
> > You are awesome, thank you!
> > --
> > Deet-doot-dot, I am a bot.
> > https://korg.docs.kernel.org/patchwork/pwbot.html
> >
> >
> >
>
> Luiz,
>
> I think patchwork borked when picking up this one, here's what the commit
> trailer looks like in next:
>
> Reported-by: Wren Turkal <wt@xxxxxxxxxxxxxxxx>
> Reported-by: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
> Closes: https://lore.kernel.org/linux-bluetooth/1713449192-25926-2-git-send-email-quic_zijuhu@xxxxxxxxxxx/
> Fixes: 56d074d26c58 ("Bluetooth: hci_qca: don't use
> IS_ERR_OR_NULL() with gpiod_get_optional()")
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> Tested-by: Wren Turkal" <wt@xxxxxxxxxxxxxxxx>
> Reported-by: Wren Turkal <wt@xxxxxxxxxxxxxxxx>
> Reported-by: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski<krzysztof.kozlowski@xxxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
>
> Reported-by and Reviewed-by tags are duplicated. One of the RB tags is missing
> a space.
Oh crap, should probably not trust patchwork would pick up the tags
properly, that said the pull-request was already merged, not sure if
we can do something about it now?
--
Luiz Augusto von Dentz
