On 4/24/2024 11:24 PM, quic_zijuhu wrote:
> On 4/24/2024 10:52 PM, Bartosz Golaszewski wrote:
>> On Wed, 24 Apr 2024 at 16:46, Krzysztof Kozlowski
>> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>>>
>>> On 24/04/2024 14:29, Bartosz Golaszewski wrote:
>>>> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>>>>
>>>
>>>> qcadev->susclk = devm_clk_get_optional(&serdev->dev, NULL);
>>>> if (IS_ERR(qcadev->susclk)) {
>>>> @@ -2355,10 +2360,13 @@ static int qca_serdev_probe(struct serdev_device *serdev)
>>>> qcadev->bt_en = devm_gpiod_get_optional(&serdev->dev, "enable",
>>>> GPIOD_OUT_LOW);
>>>> if (IS_ERR(qcadev->bt_en)) {
>>>> - dev_warn(&serdev->dev, "failed to acquire enable gpio\n");
>>>> - power_ctrl_enabled = false;
>>>> + dev_err(&serdev->dev, "failed to acquire enable gpio\n");
>>>> + return PTR_ERR(qcadev->bt_en);
> please think about for QCA2066. if it is returned from here. BT will
> not working at all. if you don't return here. i will be working fine
> for every BT functionality.
sorry, correct a type error, it is QCA6390 not QCA2066.
> NAK again by me.
>
>>>> }
>>>>
>>>> + if (!qcadev->bt_en)
>>>> + power_ctrl_enabled = false;
>>>
>>> This looks duplicated - you already have such check earlier.
>>>
>>
>> It's under a different switch case!
>>
>> Bartosz
>
>
