On 4/24/2024 10:08 PM, Luiz Augusto von Dentz wrote: > Hi Bartosz, > > On Wed, Apr 24, 2024 at 10:00 AM Bartosz Golaszewski > <bartosz.golaszewski@xxxxxxxxxx> wrote: >> >> On Wed, 24 Apr 2024 at 15:53, quic_zijuhu <quic_zijuhu@xxxxxxxxxxx> wrote: >>> >>>>>> >>>>>> Please slow down here. Zijun's patch works and Bartosz's patch does not. >>>>>> I don't think Zijun means any ill intent. I am replying to Bartosz's >>>>>> patch right now. >>>>> >>>>> Ok, that is great feedback, so I might be picking up the Zijun v7 set >>>>> if we don't find any major problems with it. >>>>> >>>> >>>> Luiz, >>>> >>>> Please consider my alternative[1] also tested by Wren. Zijun's usage >>>> of GPIO API is wrong. >>>> >>> why is it wrong ? >>> >> >> I have already told you that at least three times. But whatever, let >> me repeat again: gpiod_get_optional() returns NULL if the given GPIO >> is not assigned to the device in question OR a pointer to a valid GPIO >> descriptor. Anything else returned by it is an error and the driver >> must abort probe(). > > Ok, but there are other fixes on top of it: > as i commented with Bartosz's solution, it maybe break lunched product's BT functionality for his solution. > https://patchwork.kernel.org/project/bluetooth/patch/1713932807-19619-3-git-send-email-quic_zijuhu@xxxxxxxxxxx/ > > I guess that could go in but it would really help if you guys could > work together so we don't have more competing solutions. > >> >> Bart > > >
