On 4/22/2024 11:30 PM, quic_zijuhu wrote: > On 4/11/2024 9:58 PM, Von Dentz, Luiz wrote: >> Hi, >> >> How about resending them? >> >> Also we are getting pretty bad feedback from QCA drivers: >> >> https://lore.kernel.org/linux-bluetooth/31bb6e18-ecee-49b3-87d7-50ab53e07447@xxxxxxxxxxxxxxxx/ >> >> Do you guys ever test your drivers with more traditional Linux distros that actually runs bluetoothd daemon? >> ________________________________ >> From: quic_zijuhu <quic_zijuhu@xxxxxxxxxxx> >> Sent: Wednesday, April 10, 2024 11:02 PM >> To: Von Dentz, Luiz <luiz.von.dentz@xxxxxxxxx>; marcel@xxxxxxxxxxxx <marcel@xxxxxxxxxxxx> >> Subject: RFC for Qualcomm Bluetooth patches >> >> Hi Luiz, marcel >> >> could you have comments for several Qualcomm BT patches under below link. >> https://patchwork.kernel.org/project/bluetooth/list/ >> >> >> A) >> tile: [v3] Bluetooth: qca: Fix crash when use tool btattach for QCA_ROME >> >> the original v1 fix was firstly posted by me at 2024-01-11, and Johan Hovold <johan+linaro@xxxxxxxxxx> recently also >> have a similar fix with title "Bluetooth: qca: fix NULL-deref on non-serdev setup" >> >> B) >> Bluetooth: qca: Add tool btattach support for more QCA soc types >> [v1] tools/btattach: Add support for all QCA soc_types >> >> these patches make tool btattach support more Qualcomm BT controllers. >> >> C) >> [v2,RESEND] Bluetooth: btusb: Fix triggering coredump implementation for QCA >> >> this fix is for QCA controller with USB interface. the fix for UART interface has been merged >> by below commit: >> Fixes: 6abf9dd26bb1 ("Bluetooth: qca: Fix triggering coredump implementation") >> > Hi Luiz,marcel > let me list my changes for QCA controllers with priority from high to > low for you to code review and pick up. they are listed by tile > following change link > > 1) > Bluetooth: qca: Support downloading board id specific NVM for WCN7850 > https://patchwork.kernel.org/project/bluetooth/patch/1713340174-1304-1-git-send-email-quic_zijuhu@xxxxxxxxxxx/ > > 2) the issue you mentioned are fixed by below changes > [v5,1/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 > https://patchwork.kernel.org/project/bluetooth/patch/1713771497-5733-2-git-send-email-quic_zijuhu@xxxxxxxxxxx/ > > [v5,2/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 after > disable then warm reboot > https://patchwork.kernel.org/project/bluetooth/patch/1713771497-5733-3-git-send-email-quic_zijuhu@xxxxxxxxxxx/ > > 3) i also have mentioned below fix as shown in last mail. > [v2,RESEND] Bluetooth: qca: Fix crash when btattach BT controller QCA_ROME > https://patchwork.kernel.org/project/bluetooth/patch/1713796702-22861-1-git-send-email-quic_zijuhu@xxxxxxxxxxx/ > > 4) below changes will improve code quality. > [v1,RESEND] Bluetooth: Remove 3 repeated macro definitions > https://patchwork.kernel.org/project/bluetooth/patch/1713797510-24495-1-git-send-email-quic_zijuhu@xxxxxxxxxxx/ > > [v1,RESEND] Bluetooth: hci_conn: Remove a redundant check for HFP offload > https://patchwork.kernel.org/project/bluetooth/patch/1713797194-22982-1-git-send-email-quic_zijuhu@xxxxxxxxxxx/ > > [v1,RESEND] Bluetooth: btusb: Correct timeout macro argument used to > receive control message > https://patchwork.kernel.org/project/bluetooth/patch/1713797830-24600-1-git-send-email-quic_zijuhu@xxxxxxxxxxx/ these changes which will improve code quality have been merged. Hi Luiz, marcel, hope you will take time to code review functionality 1) and bug fixes 2). thanks.
