Re: [PATCH 0/2] Bluetooth: qca: fix NULL-deref on non-serdev setup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/22/2024 11:02 PM, Johan Hovold wrote:
> On Mon, Apr 22, 2024 at 09:53:48PM +0800, quic_zijuhu wrote:
>> On 4/22/2024 9:43 PM, Johan Hovold wrote:
>>> On Mon, Apr 22, 2024 at 09:30:28PM +0800, quic_zijuhu wrote:
>>>> On 4/22/2024 9:20 PM, Johan Hovold wrote:
> 
>>>> NAK for your [PATCH 1/2] since the null checking is redundant with your
>>>> [PATCH 2/2].
>>>
>>> I explained in the cover letter why it is split up like this. If you
>>> don't bother reading, then we will not bother listening to you.
>>>
>>>> NAK for your [PATCH 2/2], since it is same with my earlier fix
>>>> https://lore.kernel.org/all/1704960978-5437-1-git-send-email-quic_zijuhu@xxxxxxxxxxx/
>>>> my new patchset for btattach tool still has this change.
>>>
>>> The fix does not depend on your btattach series, which has also been
>>> rejected.
>>>
>> these my v1 and v2 for this issue which are earlier then yours.
>> they are not rejected but not responded.
>>
>> https://lore.kernel.org/all/bf74d533-c0ff-42c6-966f-b4b28c5e0f60@xxxxxxxxxxxxx/
>> https://lore.kernel.org/all/1704970181-30092-1-git-send-email-quic_zijuhu@xxxxxxxxxxx/
> 
> Here is your *v3* as part of the rejected btattach series:
> 
> 	https://lore.kernel.org/all/1713409913-13042-2-git-send-email-quic_zijuhu@xxxxxxxxxxx/
> 
no, v3 is a separate patch here and not was rejected.
https://lore.kernel.org/all/1710912504-25416-1-git-send-email-quic_zijuhu@xxxxxxxxxxx/
and it was sent after your patch.

then i included the fix into a patch serials for tool btattach shown by
below link
https://lore.kernel.org/all/1713358336-29619-2-git-send-email-quic_zijuhu@xxxxxxxxxxx/
you reviewed my the serials and also did not rejected the fix.
and it also doesn't get any negative comments.

> Apparently you had earlier also sent it separately, I see now in lore.
> It's all a big mess.
> 
>>> You clearly have some learning to do on how to interact with the kernel
>>> community and to write proper commit messages and patches. If you start
>>> listening to feedback and try not to piss everyone off perhaps you can
>>> even get your patches merged one day. [1][2]
> 
> Johan





[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux