On 22/04/2024 12:05, quic_zijuhu wrote: >>> 3) qca_serdev_shutdown() is serdev's shutdown and not hdev's shutdown() >>> it should not and also never get chance to be invoked even if BT is >>> disabled at above 2) step. qca_serdev_shutdown() need to send the VSC >>> to reset controller during warm reset phase of above 2) steps. >> >> Anyway, any explanation providing background how you are fixing this >> issue while keeping *previous problem fixed* is useful but should be >> provided in commit msg. I asked about this two or three times. >> >> BTW, provide here exact kernel version you tested this patches with. >> Also the exact hardware. >> > there are almost no commit with tag Tested-by also provide exact kernel ?!? So this was not tested at all by you on mainline kernel and you push downstream patch? That's how shall we understand this? > version. for one type bt controller. different h/w has different config. > important is that this issue is fixed in reported H/W and don't cause > issue for other issue. Amount of pushback from your side and ignoring questions raised during review is way too much. > > let us stop here and wait for other comments. So why do you push again in v5? Best regards, Krzysztof
