On Thu, Apr 18, 2024 at 11:11:51AM +0800, Zijun Hu wrote: > hu->serdev is nullptr and will cause nullptr dereference if qca_setup() > is called by non-serdev device, fixed by nullptr checking before access. As I explained elsewhere, this is not a fix. It is only something you need *after* you added the later patches in this series. This needs to be reflected in the commit summary and commit message as I already told you: https://lore.kernel.org/all/Zh91zq13nZvH3-Yj@xxxxxxxxxxxxxxxxxxxx/ Johan