Re: [PATCH] net/socket: Ensure length of input socket option param >= sizeof(int)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] net/socket: Ensure length of input socket option param >= sizeof(int)
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Tue, 9 Apr 2024 11:27:57 -0700
Authentication-results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="O9ekr+1j"
Authentication-results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
Cc: eric.dumazet@xxxxxxxxx, edumazet@xxxxxxxxxx, johan.hedberg@xxxxxxxxx, linux-bluetooth@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, luiz.dentz@xxxxxxxxx, marcel@xxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, pmenzel@xxxxxxxxxxxxx, syzbot+d4ecae01a53fd9b42e7d@xxxxxxxxxxxxxxxxxxxxxxxxx, syzkaller-bugs@xxxxxxxxxxxxxxxx
In-reply-to: <tencent_88401767377846C9736D0363C96C23BB4405@qq.com>
References: <7cf0848b-f44c-42ad-848a-369a249bff77@gmail.com> <tencent_88401767377846C9736D0363C96C23BB4405@qq.com>

On Tue,  9 Apr 2024 22:01:45 +0800 Edward Adam Davis wrote:
> > I think I gave my feedback already.
> > 
> > Please do not ignore maintainers feedback.
> > 
> > This patch is absolutely wrong.
> > 
> > Some setsockopt() deal with optlen == 1 just fine, thank you very much.  
>
> It's better to use evidence to support your claim, rather than your "maintainer" title.

Run selftests.

References:
- Re: [PATCH] net/socket: Ensure length of input socket option param >= sizeof(int)
  - From: Eric Dumazet
- Re: [PATCH] net/socket: Ensure length of input socket option param >= sizeof(int)
  - From: Edward Adam Davis

Prev by Date: [bluetooth-next:master] BUILD SUCCESS 215c4704208b80922eaf72c4c15a6c87f0b4482a
Next by Date: Re: QCA6390 bluetooth doesn't work after warm boot or disable/reenable
Previous by thread: Re: [PATCH] net/socket: Ensure length of input socket option param >= sizeof(int)
Next by thread: RE: net/socket: Ensure length of input socket option param >= sizeof(int)
Index(es):
- Date
- Thread

[Index of Archives] [Bluez Devel] [Linux Wireless Networking] [Linux Wireless Personal Area Networking] [Linux ATH6KL] [Linux USB Devel] [Linux Media Drivers] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Big List of Linux Books]