Re: [PATCH BlueZ v2 1/1] Increase autoconnect timeout max from 16.384s to 20.480s

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Mahesh,


Thank you for sending version 2.

Am 04.04.24 um 13:40 schrieb Mahesh Talewad:
  - In current implementation Autoconnecttimeout max value is
    16384[0x4000] msecs.
  - Since some controllers need some more time to respond to cmd
    'LE Extended Create Connection' hence increased this
    Autoconnecttimeout max value to 20480[0x5000] msecs.

For ex:
- In some controllers, If we include LE-Coded PHY in the initiating
  PHY List, BLE INIT scheduler selects the 1M and Coded PHY scanning
  as an initiator in round robin manner, and due to this available
  bandwidth gets distributed between 1M and Coded PHY, and this
  results in longer time taken for connection establishment by
  the controller.
- If ref device is advertising at 1.5 sec intervals, with create
  connection timeout of 4 sec,  the controller gets only 2 opportunities
  for the connection. Without the inclusion of LE-coded PHY,
  DUT takes ~3.8 sec for the connection establishment.Hence as described
  in above point  with the inclusion of LE-coded PHY it is difficult to
  achieve 100% connection success with the device having
  adv interval of 1.5 sec.

Hence increased Autoconnecttimeout max value to 20480[0x5000] msecs.

Signed-off-by: Mahesh Talewad <mahesh.talewad@xxxxxxx>
---
  src/main.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main.c b/src/main.c
index f774670e4..081a388ad 100644
--- a/src/main.c
+++ b/src/main.c
@@ -657,7 +657,7 @@ static void parse_le_config(GKeyFile *config)
  		  &btd_opts.defaults.le.autoconnect_timeout,
  		  sizeof(btd_opts.defaults.le.autoconnect_timeout),
  		  0x0001,
-		  0x4000},
+		  0x5000},  /*max val: 20480 msec*/

Please add spaces after /* and before */.

  		{ "AdvMonAllowlistScanDuration",
  		  &btd_opts.defaults.le.advmon_allowlist_scan_duration,
  		  sizeof(btd_opts.defaults.le.advmon_allowlist_scan_duration),


Kind regards,

Paul




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux