pe, 2024-03-29 kello 00:20 +0100, Werner Sembach kirjoitti: > Hi Luiz, > > Am 28.03.24 um 15:17 schrieb Luiz Augusto von Dentz: > > Hi Werner, > > > > On Thu, Mar 28, 2024 at 9:18 AM Werner Sembach <wse@xxxxxxxxxxxxxxxxxxx> wrote: > > > From: Christoffer Sandberg <cs@xxxxxxxxx> > > > > > > For HW variants 0x17, 0x18 and 0x19 LE Coded PHY causes scan and > > > connection issues when enabled. This patch disables it through > > > the existing quirk. > > > > > > Signed-off-by: Christoffer Sandberg <cs@xxxxxxxxx> > > > Signed-off-by: Werner Sembach <wse@xxxxxxxxxxxxxxxxxxx> > > > Cc: <stable@xxxxxxxxxxxxxxx> > > > --- > > > drivers/bluetooth/btintel.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c > > > index cdc5c08824a0a..6dbfb74d0adf9 100644 > > > --- a/drivers/bluetooth/btintel.c > > > +++ b/drivers/bluetooth/btintel.c > > > @@ -2881,6 +2881,8 @@ static int btintel_setup_combined(struct hci_dev *hdev) > > > case 0x17: > > > case 0x18: > > > case 0x19: > > > + /* 0x17, 0x18 and 0x19 have issues when LE Coded PHY is enabled */ > > > + set_bit(HCI_QUIRK_BROKEN_LE_CODED, &hdev->quirks); > > If it is just these 3 then we are missing a break here. > > The cases are not added by the patch, the fallthrough was here before. This > patch just adds this quirk for these 3 cases on top to the other things done > below, aka the fallthrough is intentional. See https://docs.kernel.org/next/process/deprecated.html#implicit-switch-case-fall-through > > Best regards, > > Werner > > > > > > case 0x1b: > > > case 0x1c: > > > /* Display version information of TLV type */ > > > -- > > > 2.34.1 > > > > > -- Pauli Virtanen
