Re: [PATCH BlueZ] avctp: Remove redundant UUID checks and additions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Mar 22, 2024 at 2:39 PM Xiao Yao <xiaokeqinhealth@xxxxxxx> wrote:
>
> From: Xiao Yao <xiaoyao@xxxxxxxxxxxxxx>
>
> ---
>  profiles/audio/avctp.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/profiles/audio/avctp.c b/profiles/audio/avctp.c
> index 8ad146df1..6199ee951 100644
> --- a/profiles/audio/avctp.c
> +++ b/profiles/audio/avctp.c
> @@ -1597,12 +1597,6 @@ static void avctp_confirm_cb(GIOChannel *chan, gpointer data)
>         if (session == NULL)
>                 return;
>
> -       if (btd_device_get_service(device, AVRCP_REMOTE_UUID) == NULL)
> -               btd_device_add_uuid(device, AVRCP_REMOTE_UUID);
> -
> -       if (btd_device_get_service(device, AVRCP_TARGET_UUID) == NULL)
> -               btd_device_add_uuid(device, AVRCP_TARGET_UUID);

Patch description makes no sense to me, this code is adding the UUIDs
of AVCTP if the device over its PSM because at this point perhaps SDP
discovery is not complete.

>         switch (psm) {
>         case AVCTP_CONTROL_PSM:
>                 avctp_control_confirm(session, chan, device);
> --
> 2.34.1
>
>


-- 
Luiz Augusto von Dentz





[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux