Re: [PATCH 2/3] Add generic descriptor support to Attribute API document

[Claudio Takahasi <claudio.takahasi@xxxxxxxxxxxxx>]

Hi,


On Wed, Feb 16, 2011 at 6:13 PM, Elvis PfÃtzenreuter <epx@xxxxxxxxxxx> wrote:
> This patch proposes extensions to Attribute API, giving access to all
> characteristic descriptors (beyond 'Description' and 'Format').
> ---
> Âdoc/attribute-api.txt | Â 28 ++++++++++++++++++++++++++++
> Â1 files changed, 28 insertions(+), 0 deletions(-)
>
> diff --git a/doc/attribute-api.txt b/doc/attribute-api.txt
> index 23808e6..5ee189e 100644
> --- a/doc/attribute-api.txt
> +++ b/doc/attribute-api.txt
> @@ -104,6 +104,14 @@ Methods      Âdict GetProperties()
>
> Â Â Â Â Â Â Â Â Â Â Â ÂPossible Errors: org.bluez.Error.InvalidArguments
>
> + Â Â Â Â Â Â Â void SetDescriptorValue(object descriptor, array{byte} value)
> +
> + Â Â Â Â Â Â Â Â Â Â Â Sets descriptor value, provided that it is writable.
> +
> + Â Â Â Â Â Â Â Â Â Â Â Possible Errors: org.bluez.Error.InvalidArguments
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â org.bluez.Error.NotAuthorized
> +
> +
> ÂProperties   string UUID [readonly]
>
> Â Â Â Â Â Â Â Â Â Â Â ÂUUID128 of this characteristic.
> @@ -143,6 +151,26 @@ Properties     string UUID [readonly]
> Â Â Â Â Â Â Â Â Â Â Â ÂFriendly representation of the Characteristic Value
> Â Â Â Â Â Â Â Â Â Â Â Âbased on the format attribute.
>
> + Â Â Â Â Â Â Â dict Descriptors [readonly]
> +
> + Â Â Â Â Â Â Â Â Â Â Â List of descriptors for this characteristic.
> +
> + Â Â Â Â Â Â Â Â Â Â Â This list contains only the descriptors not already
> + Â Â Â Â Â Â Â Â Â Â Â covered by other properties (v.g. Description, Format).
> +
> + Â Â Â Â Â Â Â Â Â Â Â Each descriptor is mapped to an unique object path,
> + Â Â Â Â Â Â Â Â Â Â Â which is the key for the dict.
> +
> + Â Â Â Â Â Â Â Â Â Â Â Each dict value is, in turn, a dict with at least
> + Â Â Â Â Â Â Â Â Â Â Â the following keys:
> +
> + Â Â Â Â Â Â Â Â Â Â Â {
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "UUID": string (descriptor UUID - mandatory),
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "Value": array of bytes (raw descriptor value -
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âoptional, shows up when value can be
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âfetched)
> + Â Â Â Â Â Â Â Â Â Â Â }
> +
>
> ÂCharacteristic Watcher hierarchy
> Â===============================
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
>

In my opinion is not a good approach to allow applications(D-Bus
clients) to change a behavior/value of the same characteristic
descriptor. bluetoothd could manage automatically writing the client
characteristic configuration and server characteristic configuration
based on the registered watchers and supported client profiles.

BR,
Claudio.
ÿô.nlj·Ÿ®‰­†+%ŠË±é¥Šwÿº{.nlj·¥Š{±ý¶â^n‡r¡öë¨è&£ûz¹Þúzf£¢·hšˆ§~†­†Ûÿÿïÿ‘ê_èæ+v‰¨þ)ßø