Re: [PATCH] CUPS lives in libexecdir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2024-02-22 at 13:06 +0000, Emil Velikov wrote:
> On Wed, 21 Feb 2024 at 11:19, Joakim Tjernlund
> <joakim.tjernlund@xxxxxxxxxxxx> wrote:
> >
> > From: Joakim Tjernlund <Joakim.Tjernlund@xxxxxxxxxxxx>
> >
> > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@xxxxxxxxxxxx>
> > ---
> >  Makefile.tools | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Makefile.tools b/Makefile.tools
> > index 044342e29..b785ebea8 100644
> > --- a/Makefile.tools
> > +++ b/Makefile.tools
> > @@ -538,7 +538,7 @@ endif
> >  endif
> >
> >  if CUPS
> > -cupsdir = $(libdir)/cups/backend
> > +cupsdir = $(libexecdir)/cups/backend
> >
>
> Is this true, can you provide some references?
>
> Looking at Debian [1] (which contrary to Arch has libexec) - backends
> are in /usr/lib. Glancing at the cups backends makefile it's using
> SERVERBIN. Casual grep shows that libexec can be applicable for
> BSD/Darwin platforms [3], which are out of scope for bluez IIRC.

on Gentoo you have:

qlist net-print/cups | grep backend
...
/usr/libexec/cups/backend/implicitclass
/usr/libexec/cups/backend/beh
/usr/libexec/cups/backend/serial
/usr/libexec/cups/backend/parallel
/usr/libexec/cups/backend/driverless-fax
/usr/libexec/cups/backend/driverless
/usr/libexec/cups/backend/cups-pdf

but now I see this in Gentoo ebuild:
        # Install in /usr/libexec always, instead of using /usr/lib/cups, as that
        # makes more sense when facing multilib support.
        sed -i -e 's:CUPS_SERVERBIN="$exec_prefix/lib/cups":CUPS_SERVERBIN="$exec_prefix/libexec/cups":g' configure ||die

        econf "${myeconfargs[@]}"

        sed -i -e "s:SERVERBIN.*:SERVERBIN = \"\$\(BUILDROOT\)${EPREFIX}/usr/libexec/cups\":" Makedefs || die
        sed -i -e "s:#define CUPS_SERVERBIN.*:#define CUPS_SERVERBIN \"${EPREFIX}/usr/libexec/cups\":" config.h || die
        sed -i -e "s:cups_serverbin=.*:cups_serverbin=\"${EPREFIX}/usr/libexec/cups\":" cups-config || die

so it appears to be a Gentoo addition.
Would perhaps
  pkg-config cups --variable=cups_serverbin
or
  cups-config --serverbin
be acceptable? If no we can just drop this and Gentoo will continue to patch bluez for cups

    Jocke
>
> -Emil
>
> [1] https://packages.debian.org/bookworm/amd64/cups-daemon/filelist
> [2] https://github.com/OpenPrinting/cups/blob/master/backend/Makefile
> [3] https://github.com/OpenPrinting/cups/blob/535fdc2b38fc3f3819233344556c45f4e8d2620d/config-scripts/cups-directories.m4#L246





[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux